Stabilize bounded CI deadlines - #28
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0thernet
left a comment
There was a problem hiding this comment.
Independent exact-head review for 9934dc5797867bbb456b467a1ea886e0cb5c2ac2: no blockers found. I verified that the diff is limited to scripts/authority-supervisor-runtime.test.ts and src/install-preflight.test.ts; production/runtime code and deadlines are unchanged. The supervisor test now subscribes to close/error before the awaited spawn/control sequence and applies the bounded wait when consuming that existing observation, removing the demonstrated missed-event race while cleaning both listeners on settlement. The installer changes raise only the two outer serialized test deadlines to 180s, consistent with the observed valid 64.1s/82.1s exact-current runs and without weakening an inner installer authority bound. git diff --check is clean, and the exact-current full local gate reported 1,766/1,766 tests plus package, CLI, site, PTY, and daemon verification green. Formal approval is unavailable because the authenticated reviewer is also the author, so this exact-SHA comment records the independent semantic review.
What changed
Why
The previous test harness could miss a fast child
closeevent and could terminate a valid second serialized install at the old 60-second outer deadline. On the exact current-main replay, the two affected installer cases completed successfully in 64.1 seconds and 82.1 seconds, which directly demonstrates that the old outer timeout was below valid bounded work under host load.Exact evidence
25a5573687ad13ace8bd5ef3f80444834f69fc8e9934dc5797867bbb456b467a1ea886e0cb5c2ac2bc407328e02c9c530ef1b9a15e34952d69675908across the current-main replaybun install --frozen-lockfile --ignore-scriptsbun run check: lint and typecheck passed; 1,766 tests passed with 97,601 assertions; site check/build, CLI build, package-policy tests, and isolated local/global consumer plus PTY/daemon lifecycle verification passedThe intervening main change updated only
package.jsonandbun.lockfor@hraness/site-footerv0.3.1; this repair changes only the two test files and was fully replayed after the dependency update.