fix(title-require): allow comments inside non-empty <title> - #1938
Merged
Merged
Conversation
- Check all text nodes inside <title> instead of only the last event, so titles mixing text with comments (e.g. Apache SSI directives) are not reported as empty - Remove the @ts-expect-error workaround for event.lastEvent - Add tests for comment-only and text-with-comment titles - Update rule docs with comment examples Fixes #1916 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Deploying htmlhint with
|
| Latest commit: |
a4b1862
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://56ae7b5f.htmlhint.pages.dev |
| Branch Preview URL: | https://fix-title-require-comments.htmlhint.pages.dev |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
All reviewed changes are covered and no unresolved issues remain.
Review effort: Lite
Findings: None
What changed in this PR
Updates title-require to correctly recognize text inside <title> elements containing comments, preventing false positives.
Changes:
- Tracks all text nodes within
<title>. - Adds regression tests for comment-related cases.
- Updates documentation and generated output.
| File | Description |
|---|---|
website/src/content/docs/rules/title-require.mdx |
Documents comment examples. |
test/rules/title-require.spec.js |
Adds regression tests. |
src/core/rules/title-require.ts |
Implements text-node tracking. |
dist/core/rules/title-require.js |
Updates compiled rule output. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<title>instead of only the last event, so titles mixing text with comments (e.g. Apache SSI directives) are not reported as empty@ts-expect-errorworkaround for event.lastEventFixes #1916