Add post type-aware taxonomy terms - #63
Open
SenseAndImage wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Situation:
The taxonomy filter is already hiding empty terms by default. However hide_empty does not respect the currently choosen post_types(s) in the query loop block and just checks for absolute emptiness (term not assigned to ANY post or page). If you loop over the custom post type "books" and select the taxonomy "author" with the query-filter block you would see author terms that are not assigned to any books if the were assigned to another post type, like "essays". These terms will however yield not result the query loop block only shows book results.
This PR:
Adds an option to the "terms" section of the block settings that allows users to exclude terms that are not assigned to the currently selected post type.