Skip to content

Fix path imports to be ESM compliant - #277

Closed
rsweeneydev wants to merge 6 commits into
huntabyte:mainfrom
rsweeneydev:main
Closed

Fix path imports to be ESM compliant#277
rsweeneydev wants to merge 6 commits into
huntabyte:mainfrom
rsweeneydev:main

Conversation

@rsweeneydev

Copy link
Copy Markdown

Fixes #276

@changeset-bot

changeset-bot Bot commented Jan 13, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 699e20e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bits-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jan 13, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bits-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2024 0:36am

@rsweeneydev

Copy link
Copy Markdown
Author

There are some upstream issues exposed by moving to module: NodeNext. You'll see them when you run svelte-check.

  1. melt-ui has similar issues with import specifiers missing file extensions.
  2. All the icon imports from phosphor throw the error below when running svelte-check
Error: Argument of type 'typeof LockKeyOpen' is not assignable to parameter of type 'ConstructorOfATypedSvelteComponent'.

Possible causes:
- You use the instance type of a component where you should use the constructor type
- Type definitions are missing for this Svelte Component. If you are using Svelte 3.31+, use SvelteComponentTyped to add a definition:
  import type { SvelteComponentTyped } from "svelte";
  class ComponentName extends SvelteComponentTyped<{propertyName: string;}> {} (ts)
                                                />
                                                <LockKeyOpen
                                                        class="absolute right-4 top-[14px] text-dark/30 sq-[22px]"

Comment thread tsconfig.json
Comment thread src/content/constants.d.ts Outdated
Comment thread .changeset/mean-socks-wait.md Outdated
Comment thread src/content/api-reference/extended-types/index.d.ts Outdated
Robert Sweeney and others added 3 commits January 13, 2024 17:27
Co-authored-by: CokaKoala <31664583+AdrianGonz97@users.noreply.github.com>
@AdrianGonz97

Copy link
Copy Markdown
Collaborator

Thank you for the PR! I think we'll wait for the Melt PR to merge first (and hopefully a phosphor-svelte one soon after) before merging this one.

@saul-atomrigs

Copy link
Copy Markdown

@AdrianGonz97 Seems like the Melt-UI PR has been merged!

@AdrianGonz97

Copy link
Copy Markdown
Collaborator

Apologies for letting this sit for so long.

Due to how large of a PR this is, and how long we've let it sit for, the merge conflicts grew to so much, it was far easier to just reimplement this again rather than resolve every conflict.

Closing in favor of #352

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Svelte component libraries should use "NodeNext" for moduleResolution, not "bundler"

3 participants