Fix HeaderMap::drain double-free if drain iterator is forgotten - #357
Merged
Conversation
hawkw
approved these changes
Nov 25, 2019
hawkw
left a comment
Contributor
There was a problem hiding this comment.
The approach used here looks correct to me. I left some comments on nits we may want to address.
| } | ||
|
|
||
| #[test] | ||
| fn drain_forget() { |
Contributor
There was a problem hiding this comment.
Should there also be a test for mem::forgetting a ValueDrain returned by a Drain?
seanmonstar
force-pushed
the
drain-double-free
branch
from
November 25, 2019 19:24
9f5df69 to
125e909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #354
cc @qwaz thanks for the report!