Skip to content

docs(contributing): add CONTRIBUTING.adoc to satisfy the armed docs gate - #16

Merged
hyperpolymath merged 2 commits into
mainfrom
arena/01a10226-awesome-haskell
Oct 3, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
arena/01a10226-awesome-haskell

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Issue

Closes the downstream half of #15 (2 red checks on the default branch, deferred from #14).

Diagnosis (both checks, at source)

  1. Governance / governance / Code quality + docs — Check documentation fails with Missing required documentation: CONTRIBUTING. The gate (hyperpolymath/standards scripts/check-docs-presence.sh) split README/LICENSE (blocking immediately) from CONTRIBUTING (warn until 2026-08-21, then blocking). The cutoff has passed; this repo never carried a CONTRIBUTING, so the red is genuine and this PR is the whole fix.

  2. Governance / governance / Guix packaging policy (Nix retired) — Package policy violation: no packaging found. The old script demanded packaging of every repo. The owner ruling of 2026-10-01 (landed upstream as fix(gates): pin what reusables fetch; gate packaging on capability standards#1120 at 22:30Z, 10 h after the red run 36863734189 timestamped 12:43Z) retires that: packaging is now gated on the repo's rsr-profile declaring reproducible-build or container. This repo is a build-less curated list with no profile ⇒ not applicable, deliberately neutral — satisfying acceptance criterion 2's "linked change with its reason". No fake guix.scm stub is added; the script flags stubs as violations. The reasoning is recorded at source in the new CONTRIBUTING.

Changes

  • Adds CONTRIBUTING.adoc at the repo root — AsciiDoc per estate doc policy, one of the paths the gate accepts and GitHub auto-discovers. Content mirrors GOVERNANCE.adoc (licensing, review rules) and MAINTAINERS, documents the awesome-list entry conventions of README.adoc, the CI contract, and the packaging-policy non-applicability rationale.
  • No workflow, pin, lockfile or README change — actions.lock, the SHA pin of governance-reusable.yml, and every other gate are untouched.

Local pre-run of the exact gate scripts

  • check-docs-presence.sh . → ✅ Core documentation present (README, LICENSE, CONTRIBUTING) (exit 0; was exit 1 before this PR)
  • check-package-policy.sh . (in the CI's script-only shape, resolver absent) → ✅ Packaging not applicable (exit 0)
  • check-licence-consistency.sh . → exit 0 (unchanged)
  • check-trusted-base.sh . → exit 0 (unchanged)
  • R5b version-string drift scan over root \*.adoc/\*.md: clean
  • Editor hygiene on the new file: LF, no trailing whitespace, final newline

🤖 Generated with Claude Code via Arena Agent Mode

The Governance workflow's 'Check documentation' step (standards
scripts/check-docs-presence.sh) promoted CONTRIBUTING from warning to
blocking on 2026-08-21; this repo has never carried one, so
'Code quality + docs' has been red on the default branch.

Adds a root CONTRIBUTING.adoc in the estate's default format (AsciiDoc),
at the location GitHub auto-discovers. Content mirrors GOVERNANCE.adoc
(licensing, review rules) and records, at source, why the Guix
packaging policy is not applicable to a build-less curated list: the
policy applies only to repos declaring reproducible-build or
container (standards#1120, owner ruling 2026-10-01).

Addresses #15.

Co-authored-by: arena-agent <297053741+arena-agent@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: d4d8e1ba-8a34-4606-a91c-a4bf93fca9f6
📥 Commits

Reviewing files that changed from the base of the PR and between f2b47d7 and 78972f5.

📒 Files selected for processing (1)
  • CONTRIBUTING.adoc

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (6)
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: Analyze (actions)
🔇 Additional comments (1)
CONTRIBUTING.adoc (1)

77-79: 📐 Maintainability & Code Quality

The licensing term is established. GOVERNANCE.adoc states that contributors agree to license their contributions under LICENSE when they submit a pull request. The CONTRIBUTING.adoc statement accurately reflects that term, so no correction is needed.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Expanded the contribution guide with guidance on eligible Haskell resources, entry formatting, contribution workflows and pull requests.
    • Added information about required documentation, workflow security and licence checks, and packaging requirements when the repository ships a build.
    • Clarified how contributors should handle unrelated failing checks and where to find governance and licence information.

Walkthrough

The pull request adds contribution guidance for Haskell resources, README entries, branches and pull requests, CI checks, packaging policy, governance, and licensing.

Changes

Contribution guidance

Layer / File(s) Summary
Contributor instructions
CONTRIBUTING.adoc
Adds guidance on eligible resources, README entry formatting, branch and pull-request practices, CI checks, packaging-policy conditions, governance, and licensing.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 3947a

The contribution guide is mergeable on the available evidence; no actionable inconsistency has been established.

Architecture Summary

Architecture risk: 🔵 Low · up to 78972

The change affects 1 system.

Changed systems: CONTRIBUTING.adoc

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — CONTRIBUTING.adoc (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in CONTRIBUTING.adoc: Adds contribution guidance covering eligible links, README entry style, branch and pull-request practices, CI checks, packaging-policy applicability, governance and licensing.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the addition of CONTRIBUTING.adoc to address the documentation gate.
Description check ✅ Passed The description explains the documentation gate failure, the new CONTRIBUTING.adoc, and the reported checks relevant to the changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit reads the guide with care
Then checks each link and entry there
It follows branches, checks, and rules
And shares the Haskell garden’s tools
With one last hop, the work is done

Comment @coderabbitai help to get the list of available commands.

The Governance workflow's 'Check documentation' step (standards
scripts/check-docs-presence.sh) promoted CONTRIBUTING from warning to
blocking on 2026-08-21; this repo has never carried one, so
'Code quality + docs' has been red on the default branch.

Adds a root CONTRIBUTING.adoc in the estate's default format (AsciiDoc),
at the location GitHub auto-discovers. Content mirrors GOVERNANCE.adoc
(licensing, review rules) and records, at source, why the Guix
packaging policy is not applicable to a build-less curated list: the
policy applies only to repos declaring reproducible-build or
container (standards#1120, owner ruling 2026-10-01).

Addresses #15.

Commit created via GraphQL createCommitOnBranch (GitHub-signed,
signature valid: true).
@hyperpolymath
hyperpolymath merged commit 678fe0b into main Oct 3, 2026
25 of 26 checks passed
@hyperpolymath
hyperpolymath deleted the arena/01a10226-awesome-haskell branch October 3, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant