fix: AGENTIC licence line + a2ml-validate-action repin - #51
Conversation
…, #669) 1. The AGENTIC.a2ml agent-constraint line "Never use AGPL license (...)" contradicts LICENCE-POLICY.adoc Rules 3 (co-developed), 4 (network services) and 5 (games), which MANDATE AGPL-3.0-or-later - and 144 copies named the retired PMPL-1.0-or-later. Replaced with a pointer to the policy plus the A2 no-automated-licence-edits rule, hardcoding no licence so it cannot go stale again. Same wording as the template fix in rsr-template-repo#45; owner-ruled sweep (2026-08-27). 2. Any workflow pinning hyperpolymath/a2ml-validate-action at 59145c7d or e558e79200 is repinned to 6ac6416f. Those two SHAs never existed: the repo itself was only created 2026-08-28 and populated by subtree split from a2ml/actions/validate (286 files, history preserved). The old pins could never resolve and made lockfile generation impossible. Direct push per owner ruling of 2026-08-28. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe agent constraints now define licence handling rules. They reference ChangesLicence policy updates
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the update of licensing instructions to align with the company's multi-license policy. While the license text changes appear correct and Codacy analysis indicates the code is up to standards, the PR is currently incomplete.
The primary concern is that the a2ml-validate-action repin mentioned in the PR title is missing from the files. This represents an acceptance criteria gap that should be resolved before merging.
About this PR
- The repin of
a2ml-validate-actionmentioned in the PR title and description appears to be missing from the code changes. Please ensure the relevant workflow files are updated as intended.
Test suggestions
- Verify that the license policy text correctly identifies Rule 1 (MPL-2.0/CC-BY-SA-4.0), Rules 3-5 (AGPL-3.0-or-later), and Rule 2 (PMPL).
- Verify that a2ml-validate-action is repinned to a valid SHA in relevant workflow files.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that a2ml-validate-action is repinned to a valid SHA in relevant workflow files.
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
Ruleset refused a direct push, so this lands by PR. Two mechanical fixes, owner-ruled:
Never use AGPL license (…)contradictsLICENCE-POLICY.adocRules 3/4/5 (which mandate AGPL for their scopes). Replaced with the policy pointer used inrsr-template-repo#45. Seestandards#646.a2ml-validate-actionrepin — the previously-pinned SHAs never existed; the repo was only created 2026-08-28 (split froma2ml/actions/validate, history preserved). Repinned to its real HEAD. Seestandards#669.🤖 Generated with Claude Code