Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #69

Merged
hyperpolymath merged 3 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 3 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 4b79034f-fb79-4d17-abab-ef5713440c07

📥 Commits

Reviewing files that changed from the base of the PR and between 7af2251 and a94324e.

📒 Files selected for processing (3)
  • .github/workflows/governance.yml
  • .github/workflows/main-estate-audit.yml
  • .github/workflows/secret-scanner.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (5)
  • GitHub Check: secret-scan / shell-secrets
  • GitHub Check: secret-scan / gitleaks
  • GitHub Check: secret-scan / rust-secrets
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: CodeQL Analysis (actions, none)
🔇 Additional comments (3)
.github/workflows/governance.yml (1)

19-22: LGTM!

.github/workflows/main-estate-audit.yml (1)

15-18: LGTM!

.github/workflows/secret-scanner.yml (1)

24-27: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated workflow permission declarations for governance, estate auditing, and secret scanning jobs.
    • Permissions are now explicitly scoped to each relevant job while retaining required security event reporting access.

Walkthrough

Three GitHub Actions workflows now declare actions, contents, and security-events permissions at job level.

Changes

Workflow permission scoping

Layer / File(s) Summary
Job-level permission declarations
.github/workflows/governance.yml, .github/workflows/main-estate-audit.yml, .github/workflows/secret-scanner.yml
The affected jobs now declare actions: read, contents: read, and security-events: write in job-level permissions blocks. Incorrectly nested declarations were removed or re-indented.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: repairing invalid YAML caused by incorrect permissions block indentation in CI workflows.
Description check ✅ Passed The description accurately explains the YAML parsing failure, the indentation correction, the preserved permissions, and the validation step.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow gate
Permissions sit at the proper state
Actions read and contents too
Security events write on cue
Three jobs now follow the chart
Clean YAML makes a tidy start

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit e913089 into main Sep 21, 2026
8 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant