Repository navigation
chore(deps): bump actions/download-artifact from 7.0.0 to 8.0.0 - #58
Merged
hyperpolymath merged 1 commit intoFeb 27, 2026
Merged
hyperpolymath merged 1 commit into
hyperpolymath merged 1 commit into
Conversation
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 7.0.0 to 8.0.0. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@37930b1...70fc10c) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-version: 8.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
hyperpolymath
approved these changes
Feb 27, 2026
hyperpolymath
deleted the
dependabot/github_actions/actions/download-artifact-8.0.0
branch
February 27, 2026 14:50
hyperpolymath
added a commit
that referenced
this pull request
Sep 30, 2026
…us + inline directives honoured (#881) > **Stacked on #877** (itself on #876). The base retargets to `main` once #877 lands. Squash automerge will be armed then, not before: armed now, it would merge into #877's branch. ## Why A Hypatia `hardcoded_tmp` alert on launch-scaffolder#46 exposed a real CWE-377 defect in the launcher generator. That was fixed upstream in launch-scaffolder #54/#58/#62. The rule itself was part of the problem: | Input | Before | After | |---|---|---| | `PID_FILE="/tmp/x.pid"` | fires | **fires** (positive control) | | `d=$(mktemp -d /tmp/foo.XXXXXX)`, the rule's own advice | **fires** | clean | | `# comment mentioning "/tmp/"` | **fires** | clean | | `/tmp` line under `tests/fixtures/`, `test/`, `lib/rules/`, `scripts/fix-scripts/` | **fires** | suppressed | | `# hypatia: allow content_patterns/hardcoded_tmp -- …` | **silently ignored** | honoured | ## Changes - **Remediation text.** It now separates pid/state files, which the next run must re-find (per-user `${XDG_RUNTIME_DIR:-${XDG_STATE_HOME:-$HOME/.local/state}}/<app>/`), from scratch files (`mktemp -d` with no `/tmp` template, plus `trap … EXIT`). The old text said "use mktemp", which is the wrong cure for a pid file. - **Own-cure skip.** `skip_comment_lines: true`, plus a new generic rule key `skip_if_line_matches` (here `~r/\bmktemp\b/`). - **Training-corpus exemption.** Added under `"content_patterns"`, the key the findings are **emitted** under in `cli.ex`. A `"cicd_rules"` key would be vacuous. - **Inline directives.** `hypatia: allow <module>/<rule>` is now honoured by the content engine under either module spelling. Rule ids are atoms, so they are stringified before `inline_allowed?/4`. - **Line-1 fix.** Line 1 no longer treats the file's **last** line as its "previous line" (`Enum.at(lines, -1)` wraps around). - **Docs.** The `.hypatia-ignore` header and `.claude/CLAUDE.md` now document the two-spelling trap and the directive behaviour. ## Not changed, deliberately - `applies_to` stays `["*.sh"]`. Widening it to `*.rs` would flag `#[cfg(test)]` literals under `src/`, and cicd_rules has no Rust comment stripping. - The file-level `hypatia: allow` form is still not wired for content patterns. CLAUDE.md now says so. ## Trade-off, stated plainly After this PR, fixtures under `tests/` are no longer scanned for this rule. On the launch-scaffolder side, the generator's own literal-pinned tests (`DEFAULT_PID_LINE`) are now the detector for a `/tmp` regression. ## Verification - `test/hardcoded_tmp_pipeline_test.exs` has 16 tests running the **real** pipeline (`collect_findings` → normalise → suppress), never a hand-built finding. - Four mutants were each killed: | Mutant | Red tests | |---|---| | Exemption key renamed | 4 | | mktemp skip removed | 1 | | `n > 1` guard reverted | 1 | | `inline_allowed?` clause removed | 3 | - Full suite: 1689 tests, 0 failures. `mix compile --warnings-as-errors --force` is clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/download-artifact from 7.0.0 to 8.0.0.
Release notes
Sourced from actions/download-artifact's releases.
Commits
70fc10cMerge pull request #461 from actions/danwkennedy/digest-mismatch-behaviorf258da9Add change docsccc058eFix linting issuesbd7976bAdd a setting to specify what to do on hash mismatch and default it toerrorac21fcfMerge pull request #460 from actions/danwkennedy/download-no-unzip15999bfAdd note about package bumps974686eBump the version tov8and add release notesfbe48b1Update test names to make it clearer what they do96bf374One more test fixb8c4819Fix skip decompress testDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)