Skip to content

docs(metadata): clarify scalar rewrite and config command errors - #50

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/40-clarify-rewrite-scalar-errors
Sep 23, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/40-clarify-rewrite-scalar-errors

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Carries forward the one commit of #47 that is not already on main.

Why this exists

Four of #47's five commits landed via the #46 squash (552ecf4). Only
4cac602 carried content that is still absent from main, so rather than
force-push over CodeRabbit's branch or discard the work, that single commit is
cherry-picked here with -x. Authorship is preserved — the commit is still
authored by coderabbitai[bot]; this session signs only as committer.

What it changes

Documentation only. No behaviour change, no test change. Two files, +12 -5.

Every claim in the new doc comments was verified against main at 552ecf4
before being carried, rather than taken on the original PR's word:

documented error path verified against
refuses the read-only DEED dialect if block.is_deed() { bail! }
new_value inserted verbatim, no escaping rewritten.push_str(new_value)
key absent, or names a list the two bail!s above the scan
parsed but not safely locatable if !patched { bail! }

The pre-existing docstring named only two of those five error paths, so this is
a correctness fix to the documentation, not a rewording.

Verification

  • cargo test --workspace — 84 passed, 0 failed (73 unit + 5 deed_corpus
    • 6 round_trip).
  • Subject line trimmed to 64 chars; the bot's original was 73, one over the
    estate's 72-char threshold.
  • Commit is signed (%G? = G).

Closes #47.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo

Carries forward the one commit of #47 that is not already on main: four
of its five commits landed via the #46 squash (552ecf4), leaving 4cac602
as the sole unique content. Authorship is preserved.

Documentation only -- no behaviour change. Every claim in the new
doc comments was verified against main at 552ecf4 before carrying it:

  - refuses the read-only DEED dialect  -> `if block.is_deed() { bail! }`
  - `new_value` inserted verbatim       -> `rewritten.push_str(new_value)`
  - key absent, or names a list         -> the two `bail!`s above the scan
  - parsed but not safely locatable     -> `if !patched { bail! }`

The pre-existing docstring named only two of those five error paths, so
this is a correctness fix to the documentation, not a rewording.

(cherry picked from commit 4cac602)

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo
@coderabbitai

coderabbitai Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 13 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7f307a90-5fef-48eb-98f9-eae151be1c4b

📥 Commits

Reviewing files that changed from the base of the PR and between 552ecf4 and f1065a7.

📒 Files selected for processing (2)
  • crates/launcher-common/src/metadata_block.rs
  • crates/launcher/src/cmd_config.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 535947a into main Sep 23, 2026
16 checks passed
@hyperpolymath
hyperpolymath deleted the docs/40-clarify-rewrite-scalar-errors branch September 23, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant