docs(metadata): clarify scalar rewrite and config command errors - #50
Merged
Merged
Conversation
Carries forward the one commit of #47 that is not already on main: four of its five commits landed via the #46 squash (552ecf4), leaving 4cac602 as the sole unique content. Authorship is preserved. Documentation only -- no behaviour change. Every claim in the new doc comments was verified against main at 552ecf4 before carrying it: - refuses the read-only DEED dialect -> `if block.is_deed() { bail! }` - `new_value` inserted verbatim -> `rewritten.push_str(new_value)` - key absent, or names a list -> the two `bail!`s above the scan - parsed but not safely locatable -> `if !patched { bail! }` The pre-existing docstring named only two of those five error paths, so this is a correctness fix to the documentation, not a rewording. (cherry picked from commit 4cac602) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo
Contributor
|
Warning Review limit reachedNext included review available in 13 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries forward the one commit of #47 that is not already on
main.Why this exists
Four of #47's five commits landed via the #46 squash (
552ecf4). Only4cac602carried content that is still absent frommain, so rather thanforce-push over CodeRabbit's branch or discard the work, that single commit is
cherry-picked here with
-x. Authorship is preserved — the commit is stillauthored by
coderabbitai[bot]; this session signs only as committer.What it changes
Documentation only. No behaviour change, no test change. Two files, +12 -5.
Every claim in the new doc comments was verified against
mainat552ecf4before being carried, rather than taken on the original PR's word:
if block.is_deed() { bail! }new_valueinserted verbatim, no escapingrewritten.push_str(new_value)bail!s above the scanif !patched { bail! }The pre-existing docstring named only two of those five error paths, so this is
a correctness fix to the documentation, not a rewording.
Verification
cargo test --workspace— 84 passed, 0 failed (73 unit + 5deed_corpusround_trip).estate's 72-char threshold.
%G?=G).Closes #47.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WPSJ7fBhVAMcpSffCBWUDo