Skip to content

ci(secret-scan): rename caller job key secret-scan -> scan (D243) - #52

Merged
hyperpolymath merged 1 commit into
mainfrom
ci/secret-scan-floor-key
Oct 1, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
ci/secret-scan-floor-key

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

What

Rename the secret-scanner caller job key secret-scan → scan in .github/workflows/secret-scanner.yml, so the check context becomes scan / gitleaks — the context the estate Secret-Scan-Floor ruleset (D243/D244) requires. One-line change; reusable pin, triggers and permissions unchanged. actionlint output is identical before and after.

Commit created via GraphQL createCommitOnBranch (GitHub-signed, signature valid: true).

🤖 Generated with Claude Code

https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK

Secret-Scan-Floor (D243/D244) requires the context `scan / gitleaks` estate-wide. The caller job key here was `secret-scan`, which emits `secret-scan / gitleaks` and can never satisfy the floor. Rename only; the reusable pin and permissions are unchanged.

actionlint output identical before and after.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 8b0a4e04-7d8e-4c27-9875-6435e740cdd5

📥 Commits

Reviewing files that changed from the base of the PR and between ed3e94f and 6bb9e69.

📒 Files selected for processing (1)
  • .github/workflows/secret-scanner.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (5)
  • GitHub Check: semgrep-cloud-platform/scan
  • GitHub Check: call-estate-audit / estate-audit
  • GitHub Check: CodeQL Analysis (rust)
  • GitHub Check: CodeQL Analysis (actions)
  • GitHub Check: check
🔇 Additional comments (1)
.github/workflows/secret-scanner.yml (1)

18-18: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated the label used by the internal security-scanning workflow. Secret scanning continues to run using the existing process and configuration, and the checks performed remain unchanged. This maintenance update has no effect on product features or behaviour. No changes to how the application is used are included in this release.

Walkthrough

The secret scanner workflow job identifier changed from secret-scan to scan. The reusable workflow and secret inheritance remain unchanged.

Changes

Secret scanner workflow

Layer / File(s) Summary
Rename scanner job
.github/workflows/secret-scanner.yml
The job identifier changed from secret-scan to scan. The reusable workflow and inherited secrets remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 6bb9e

The scanner check now uses the intended scan / gitleaks context, with no checked-in consumer depending on the old name. No concrete merge blocker is established; the external estate ruleset was not available to verify.

Architecture Summary

Architecture risk: 🔵 Low · up to 6bb9e

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/secret-scanner.yml: The job identifier changed from secret-scan to scan; its reusable workflow and secret inheritance remain unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the CI job-key rename from secret-scan to scan and matches the main change.
Description check ✅ Passed The description directly explains the job-key rename, its required check context, and the unchanged workflow settings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the scanner’s name,
The workflow keeps its call the same.
Inherited secrets stay in place,
A shorter label takes its space.
Then off I hop, content and neat.

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit f34fa91 into main Oct 1, 2026
12 checks passed
@hyperpolymath
hyperpolymath deleted the ci/secret-scan-floor-key branch October 1, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant