Skip to content

docs: add Signed commits section to CONTRIBUTING - #61

Merged
hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218
Oct 1, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
docs/signing-policy-d218

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

This repo's default branch is covered by the zero-bypass Require-Signed-Commits ruleset, and rebase-merge is off. The section tells contributors what that requires:

  • People and interactive agents sign with an SSH signing key.
  • Apps, bots and workflows write through the API, so GitHub signs their commits.
  • PRs are merged with squash.

If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).

This is a docs-only change. The commit was created through createCommitOnBranch, so GitHub signs it.

🤖 Generated with Claude Code

https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f

Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: da6a30b1-ac67-463f-8418-f4c4e598c236

📥 Commits

Reviewing files that changed from the base of the PR and between f97ff35 and f6bd899.

📒 Files selected for processing (1)
  • .github/CONTRIBUTING.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (10)
  • GitHub Check: governance / Guix primary / Nix fallback policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Security policy checks
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: Hypatia Neurosymbolic Analysis
  • GitHub Check: trufflehog
  • GitHub Check: analyze (actions, none)
🔇 Additional comments (1)
.github/CONTRIBUTING.md (1)

129-130: 🗄️ Data Integrity & Integration

Confirm the live merge and bypass settings before documenting them as current.

The Require-Signed-Commits ruleset is active for ~DEFAULT_BRANCH and contains required_signatures. However, the response does not establish that it has zero bypass actors because bypass_actors is null. The repository response also omits allow_squash_merge and allow_rebase_merge. Keep these statements conditional until authoritative settings confirm them, or update the repository configuration to match the guidance.


📝 Summary

Summary by CodeRabbit

  • Documentation
    • Added contribution guidance on signed commits, including signing requirements, accepted methods for people and automated workflows, and how to handle unsigned commits.
    • Clarified that pull requests use squash merges and that rebase merges are unavailable.

Walkthrough

The contribution guide adds signed-commit requirements for commits reaching the default branch. It describes signing methods, merge behaviour and steps for replacing unsigned commits on a pull request branch.

Changes

Signed commit guidance

Layer / File(s) Summary
Signing requirements and workflows
.github/CONTRIBUTING.md
The guide requires signed commits and describes SSH signing for people and interactive agents, API or signed-push action commits for apps, bots and workflows, and squash merges. It states that unsigned pull request branch commits block merging, gives git cherry-pick -S as a way to recreate a branch, and says rebase-merge is disabled.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to f6bd8

This documentation-only change has no established merge-blocking defect. The live repository settings have not been independently confirmed.

Architecture Summary

Architecture risk: 🔵 Low · up to f6bd8

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/CONTRIBUTING.md: Adds guidance requiring signed commits on the default branch, specifying SSH signing setup for people and interactive agents, API-based commits for apps, bots and workflows, and squash merges. It states that unsigned commits on a PR branch block merging, gives git cherry-pick -S as a way to recreate a signed branch, and says rebase-merge is disabled.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the purpose and main changes, but it omits the required RSR Quality Checklist and dedicated Testing section from the repository template. It also does not record which checkli… Add the RSR Quality Checklist with applicable items selected. Add a Testing section that states the checks performed or explains why tests are not applicable. Confirm that the documentation update requirement is satisfied. Add a Screenshots…
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the documentation change in the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the purpose and main changes, but it omits the required RSR Quality Checklist and dedicated Testing section from the repository template. It also does not record which checklist items apply or confirm test and documentation checks.

Resolution

Add the RSR Quality Checklist with applicable items selected. Add a Testing section that states the checks performed or explains why tests are not applicable. Confirm that the documentation update requirement is satisfied. Add a Screenshots section only if relevant; otherwise state that screenshots are not applicable.

  • Fix all pre-merge checks with AI
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit signs each commit with care,
SSH keys are ready there.
Squash the branch, then send it through,
Signed commits mark the work as true.
The rabbit hops away, content.

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 80 issues detected

Severity Count
🔴 Critical 6
🟠 High 42
🟡 Medium 32

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "Job `triage` in label-triage.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).",
    "type": "missing_timeout_minutes",
    "file": "label-triage.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium",
    "recipe_id": "recipe-add-workflow-timeout-minutes",
    "job": "triage"
  },
  {
    "reason": "Job `sync` in labels.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).",
    "type": "missing_timeout_minutes",
    "file": "labels.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium",
    "recipe_id": "recipe-add-workflow-timeout-minutes",
    "job": "sync"
  },
  {
    "line": 38,
    "reason": "job in .github/workflows/labels.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/labels.yml",
    "action": "report",
    "rule_module": "research_extensions",
    "severity": "warn"
  },
  {
    "line": 44,
    "reason": "job in .github/workflows/push-email-notify.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/push-email-notify.yml",
    "action": "report",
    "rule_module": "research_extensions",
    "severity": "warn"
  },
  {
    "line": 48,
    "reason": "job in .github/workflows/secret-scanner.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/secret-scanner.yml",
    "action": "report",
    "rule_module": "research_extensions",
    "severity": "warn"
  },
  {
    "line": 82,
    "reason": "job in .github/workflows/hypatia-scan.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/hypatia-scan.yml",
    "action": "report",
    "rule_module": "research_extensions",
    "severity": "warn"
  },
  {
    "line": 52,
    "reason": "job in .github/workflows/label-triage.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/label-triage.yml",
    "action": "report",
    "rule_module": "research_extensions",
    "severity": "warn"
  },
  {
    "line": 24,
    "reason": "job in .github/workflows/mirror.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/mirror.yml",
    "action": "report",
    "rule_module": "research_extensions",
    "severity": "warn"
  },
  {
    "line": 44,
    "reason": "job in .github/workflows/mirror.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/mirror.yml",
    "action": "report",
    "rule_module": "research_extensions",
    "severity": "warn"
  },
  {
    "line": 64,
    "reason": "job in .github/workflows/mirror.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
    "type": "RE001",
    "file": ".github/workflows/mirror.yml",
    "action": "report",
    "rule_module": "research_extensions",
    "severity": "warn"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

hyperpolymath added a commit that referenced this pull request Oct 1, 2026
)

## Why

The estate-wide **Secret-Scan-Floor** ruleset (owner ruling D243,
ruleset `24276941` on this repo) requires the status-check context
**`scan / gitleaks`** on the default branch. This caller ran inline jobs
and emitted a bare `gitleaks` context, so no PR here could satisfy the
floor.

## Change

- The inline `trufflehog`, `gitleaks` and `rust-secrets` jobs are
replaced by one call to
`hyperpolymath/standards/.github/workflows/secret-scanner-reusable.yml@74d2f66`
(the latest on standards `main`), under job key **`scan`**, with
`secrets: inherit`.
- TruffleHog is retired: the reusable deliberately dropped it as
redundant with gitleaks (see the reusable's header).
- `actionlint` is clean. This repo has no `actions.lock`, so there is no
transitive-closure risk.

## Note for open PRs

#61 (another session's) cannot satisfy the floor until this lands. After
merge it needs its checks re-run (or a rebase) so that it emits `scan /
gitleaks`.

## Role in the rollout

Positive-control pilot for D243. Measured: while only `scan / gitleaks`
was pending, `mergeStateStatus` read **BLOCKED**; once it went green,
**UNSTABLE**. So the floor gates mergeability. This PR was **not** armed
for auto-merge: `scan / gitleaks` completed (~20–60 s) before arming
could be issued, and arming an UNSTABLE PR merges it instantly. The
landing form is pending an owner decision.

## Deferred checks

- `Hypatia` (non-required) — WH008 note on `secrets: inherit`: deferred
to hyperpolymath/standards#943. The reusable
`secret-scanner-reusable.yml` header mandates `secrets: inherit` for
callers; the convention is triaged there, not per-repo.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@hyperpolymath
hyperpolymath merged commit 012fb39 into main Oct 1, 2026
22 checks passed
@hyperpolymath
hyperpolymath deleted the docs/signing-policy-d218 branch October 1, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant