docs: add Signed commits section to CONTRIBUTING - #61
Conversation
Owner ruling D218. See docs/SIGNING-POLICY.adoc in hyperpolymath/standards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (10)
🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughThe contribution guide adds signed-commit requirements for commits reaching the default branch. It describes signing methods, merge behaviour and steps for replacing unsigned commits on a pull request branch. ChangesSigned commit guidance
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to This documentation-only change has no established merge-blocking defect. The live repository settings have not been independently confirmed. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the purpose and main changes, but it omits the required RSR Quality Checklist and dedicated Testing section from the repository template. It also does not record which checklist items apply or confirm test and documentation checks. Resolution Add the RSR Quality Checklist with applicable items selected. Add a Testing section that states the checks performed or explains why tests are not applicable. Confirm that the documentation update requirement is satisfied. Add a Screenshots section only if relevant; otherwise state that screenshots are not applicable.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit signs each commit with care, Comment |
🔍 Hypatia Security ScanFindings: 80 issues detected
View findings[
{
"reason": "Job `triage` in label-triage.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).",
"type": "missing_timeout_minutes",
"file": "label-triage.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium",
"recipe_id": "recipe-add-workflow-timeout-minutes",
"job": "triage"
},
{
"reason": "Job `sync` in labels.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).",
"type": "missing_timeout_minutes",
"file": "labels.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium",
"recipe_id": "recipe-add-workflow-timeout-minutes",
"job": "sync"
},
{
"line": 38,
"reason": "job in .github/workflows/labels.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/labels.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 44,
"reason": "job in .github/workflows/push-email-notify.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/push-email-notify.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 48,
"reason": "job in .github/workflows/secret-scanner.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/secret-scanner.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 82,
"reason": "job in .github/workflows/hypatia-scan.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/hypatia-scan.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 52,
"reason": "job in .github/workflows/label-triage.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/label-triage.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 24,
"reason": "job in .github/workflows/mirror.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/mirror.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 44,
"reason": "job in .github/workflows/mirror.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/mirror.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 64,
"reason": "job in .github/workflows/mirror.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/mirror.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
) ## Why The estate-wide **Secret-Scan-Floor** ruleset (owner ruling D243, ruleset `24276941` on this repo) requires the status-check context **`scan / gitleaks`** on the default branch. This caller ran inline jobs and emitted a bare `gitleaks` context, so no PR here could satisfy the floor. ## Change - The inline `trufflehog`, `gitleaks` and `rust-secrets` jobs are replaced by one call to `hyperpolymath/standards/.github/workflows/secret-scanner-reusable.yml@74d2f66` (the latest on standards `main`), under job key **`scan`**, with `secrets: inherit`. - TruffleHog is retired: the reusable deliberately dropped it as redundant with gitleaks (see the reusable's header). - `actionlint` is clean. This repo has no `actions.lock`, so there is no transitive-closure risk. ## Note for open PRs #61 (another session's) cannot satisfy the floor until this lands. After merge it needs its checks re-run (or a rebase) so that it emits `scan / gitleaks`. ## Role in the rollout Positive-control pilot for D243. Measured: while only `scan / gitleaks` was pending, `mergeStateStatus` read **BLOCKED**; once it went green, **UNSTABLE**. So the floor gates mergeability. This PR was **not** armed for auto-merge: `scan / gitleaks` completed (~20–60 s) before arming could be issued, and arming an UNSTABLE PR merges it instantly. The landing form is pending an owner decision. ## Deferred checks - `Hypatia` (non-required) — WH008 note on `secrets: inherit`: deferred to hyperpolymath/standards#943. The reusable `secret-scanner-reusable.yml` header mandates `secrets: inherit` for callers; the convention is triaged there, not per-repo. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Adds a Signed commits section to this repo's CONTRIBUTING, per owner ruling D218. The estate policy is
docs/SIGNING-POLICY.adocin hyperpolymath/standards.This repo's default branch is covered by the zero-bypass
Require-Signed-Commitsruleset, and rebase-merge is off. The section tells contributors what that requires:If the file already had its own signing section, that section is replaced in place instead of adding a second one. Lines elsewhere that told people to sign with GPG are changed to match the policy (SSH for people).
This is a docs-only change. The commit was created through
createCommitOnBranch, so GitHub signs it.🤖 Generated with Claude Code
https://claude.ai/code/session_01WRvDivYwLSeVCJUrfjic3f