test: drop R2 c5 @test_broken marker (after KnotTheory.jl#43) - #77
Merged
hyperpolymath merged 1 commit intoJul 21, 2026
Merged
Conversation
KnotTheory.jl's r2_simplify now re-splices the severed arcs when it removes a bigon (hyperpolymath/KnotTheory.jl#43), so the trefoil's 5-colouring count survives R2 simplification and the marker would report 'unexpected pass' (a hard error) — exactly the forcing signal it was designed to emit. Restore the plain hard assertion. DO NOT MERGE before KnotTheory.jl#43: CI checks out that repo's default branch, so this assertion fails against an unfixed main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
hyperpolymath
marked this pull request as ready for review
July 21, 2026 13:07
hyperpolymath
merged commit Jul 21, 2026
27b704b
into
fix/canonicalize-idempotent
8 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
@test_brokenmarker on the R2-invariance 5-colouring assertion inserver/test_quandle_axioms.jl, restoring the plain hard@test.The marker tracked an upstream defect:
r2_simplifyin KnotTheory.jl removed a bigon without re-splicing the severed arcs, so the trefoil's extracted presentation gained 2 phantom generators and its 5-colouring count came out 25 instead of 5. That is fixed in hyperpolymath/KnotTheory.jl#43 (union-find arc re-splice + the braid strand-swap fix underneath it).Merge order — do not merge early
The
@test_brokenmechanism makes step 3 mandatory rather than optional: once #43 merges, the marker reports "unexpected pass" — a hard error — in #76's follow-up CI runs, and this PR is the remedy.Verification
With the #43 fix applied locally (Julia 1.12.6, 200-trial BR-5 corpus): the axioms suite passes fully with the hard assertion restored; the only remaining Broken mark in the repo is the BR-5
quandle_keyorder-sensitivity counter (11/200 residual, upstream KnotTheory.jl#42 — polynomial unit normalisation, deliberately kept).🤖 Generated with Claude Code