Claude/analyze repo improvements lnt sd - #4
Closed
hyperpolymath wants to merge 4 commits into
Closed
Conversation
- Create engine/src/metrics.jl: implements compute_metrics, MetricsSnapshot, metrics_summary, and supporting functions (vocabulary diversity, reference rates, coherence, convergence, novel n-grams). This was a critical missing file that prevented the JeffEngine module from loading. - Rewrite thejeffparadox_README.md: replace incorrect npm/pip placeholder with actual Julia/Hugo/Ada instructions matching the real project. - Fix rate limiting in llm_client.jl: implement token-based rate limiting that was previously stubbed out, and properly synchronize cleanup of request_times and token_counts vectors. - Improve Ada YAML parsing in game_state.adb: add line trimming, comment skipping, key-at-start-of-line matching, and quoted string handling for current_node values. https://claude.ai/code/session_01FdPFGKmDfdZYBgi2jGGoAv
- Split llm_client.jl into three focused modules: - llm_client.jl: HTTP transport, context building, generation - embedding_client.jl: embedding generation, cosine similarity - rate_limiter.jl: per-provider rate/token limiting - Wire up compute_aperture() in generate_response() via keyword arg `game`, so temperature is dynamically adjusted based on conversation metrics (vocabulary diversity, coherence). Previously this was a TODO. - Extract hardcoded model names into DEFAULT_MODELS config dict, overridable via GM_MODEL env var. - Add comprehensive tests: state persistence round-trip, rate limiter token enforcement, cosine similarity, coherence/convergence metrics, LLM client header/body/response parsing, and metrics summary. - Fix CONTRIBUTING.md: replace stale nix develop/flake.nix/just check references with actual Julia/Hugo setup instructions and correct repository structure. - Fix Containerfile: replace Ada TUI placeholder comment with actual GNAT build attempt that gracefully skips when toolchain unavailable. https://claude.ai/code/session_01FdPFGKmDfdZYBgi2jGGoAv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed — all changes already merged to main
This PR's changes were merged to main via:
25200a0): metrics.jl, README fix, rate limiter, Ada parsere02af96): boilerplate README removal, ABI template fix, CI hardening0557515): llm_client split, aperture control, expanded testsf8ea209): metrics_trend, detect_emergent_patterns, SPDX headersThe branch diverged from main after PR #2 made independent enhancements to llm_client.jl (structured error handling, provider validation), creating irreconcilable merge conflicts in the branch history. Since all substantive work is on main, closing this PR rather than force-resolving stale conflicts.