Skip to content

V-L3-B1: remove blanket #![allow(...)] in src/lib.rs — restores clippy signal #16

Description

@hyperpolymath

Context

src/lib.rs opens with:

#![allow(
    dead_code,
    clippy::too_many_arguments,
    clippy::manual_strip,
    clippy::if_same_then_else,
    clippy::vec_init_then_push,
    clippy::upper_case_acronyms,
    clippy::format_in_format_args,
    clippy::enum_variant_names,
    clippy::module_inception,
    clippy::doc_lazy_continuation,
    clippy::manual_clamp,
    clippy::type_complexity
)]

Combined with the Justfile lint target (cargo clippy -- -D warnings), this means the lint signal is hollow — the lints have already been disabled before clippy runs.

What to do

Remove the blanket allow block. Run cargo clippy --all-targets -- -D warnings and fix each lint individually:

  • dead_code — actually remove the dead code (probably the duplicate tier1::ProvenanceRecord; see V-L2-N1)
  • too_many_arguments — refactor the offending function or accept it with #[allow(...)] at the function site, with a comment explaining why
  • per-clippy lints — fix at the site

If a lint is genuinely too noisy and you keep an allow, scope it to the smallest possible item (function or module) and leave a one-line comment.

Acceptance

  • #![allow(...)] block removed from src/lib.rs
  • cargo clippy --all-targets -- -D warnings is clean
  • No new module-scoped #![allow] blocks introduced

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething is broken or behaves incorrectly

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions