Conversation
jessiethw
commented
Oct 1, 2026
jessiethw
left a comment
Collaborator
Author
There was a problem hiding this comment.
Some minor comments on the gcn_listener.py, thanks a lot @physics-png for all the work!
| 'gcn.classic.voevent.ICECUBE_CASCADE']) | ||
|
|
||
| def process_gcn(payload, root): | ||
| def process_gcn(record): #payload,root |
Collaborator
Author
There was a problem hiding this comment.
suggest dropping the commented out stuff here
| logger.info('\nRunning {} --skymap={} --time={} --alert_id={} --suffix={}'.format( | ||
| command, skymap, str(event_mjd), run_id+':'+event_id, suffix)) | ||
|
|
||
| print(params) |
Collaborator
Author
There was a problem hiding this comment.
do you need this print statement here?
| logger.warning('Failed to push to private webpage') | ||
| logger.warning(e) | ||
|
|
||
| def post_error(errMsg=None): |
Collaborator
Author
There was a problem hiding this comment.
could this be added as a general utility to slack_posters/slack.py? then it can be used in other listeners/scripts
|
|
||
| if not args.test_cascade: | ||
| print("Running on sample track . . . ") | ||
| post_error("Cannot find path to sample skymaps") |
Collaborator
Author
There was a problem hiding this comment.
do you want a posted error if testing? I think this won't really be helpful, I recommend just a logger error here, since the user will be running in testing mode to hit the else statement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LVK has switched over to Kafka listeners completely, and most other stuff is migrating away from Classic now. This PR is an overhaul of the listeners to move everything to Kafka streams.
Changes:
listeners/gw_gcn_listener.pyuses LVK's Kafka stream and updates all parameter names to matchlisteners/gcn_listener.pylistens to classic over Kakfa for IceCube alertslisteners/combine_results_classic.pyis removed (outdated and no longer used)slack_poster/logging_util.pyis added to improve logging and continuously log to a file in addition to stoutscripts/combine_results_kafka.pywill be updated in a future PR.