Skip to content

Fix ambiguous parents - #40

Open
xadler1 wants to merge 2 commits into
iconclass:mainfrom
xadler1:ambiguous_parents
Open

xadler1 wants to merge 2 commits into
iconclass:mainfrom
xadler1:ambiguous_parents

Conversation

@xadler1

@xadler1 xadler1 commented Aug 10, 2026

Copy link
Copy Markdown

Primarily fix for #39, also contains some formatting fixes.

- adhere to N K C R field order
- typo R 97DD16
- double R for 83(OVID, Metamorphoses XIV:772-804)
- remove blank lines
- remove duplicate $ line
- some double lettered items were children of more than one item
- this only fixes duplicate instances, where one of parent items was not
  double lettered
- some instaces of double lettered items still have children (if I
  understand it correctly, this probably should also be fixed)
@epoz

epoz commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Dear @xadler1

Thanks for these, really nice to get your input. (more discussions on your pull-request)
But, can we please have one fix per pull-request? In this one we are now fixing both the ambigous parents and the small typos, and the field ordering. This makes it more difficult to test/isolate, and if things go wrong more tricky to "roll-back" later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants