ci: fix Ameba linter job and specs job on current Crystal - #104
Merged
Conversation
- ameba v1.6.4 no longer compiles with current Crystal runners (undefined method 'next_string_array_token' on Crystal::Lexer); v1.7.0 supports Crystal >= 1.19. - The specs job needs development dependencies: the tartrazine require test compile-runs spec/fixtures/tartrazine.cr, so --without-development breaks spec compilation on every OS.
- keep the Markd.to_html call in the tartrazine fixture without the unused assignment - space out the macro expression in Node#inspect - drop a redundant return in the inline parser
| strategy: | ||
| matrix: | ||
| ameba-version: [v1.6.4] | ||
| ameba-version: [v1.7.0] |
Contributor
There was a problem hiding this comment.
suggestion: It might be a good idea to switch to https://github.com/crystal-ameba/github-action entirely. It's easier and more efficient.
This could be a separate PR, though.
nobodywasishere
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both CI jobs are currently failing on master:
v1.6.4no longer compiles with current Crystal (undefined method 'next_string_array_token' for Crystal::Lexerin the Build Ameba step), so linting has been broken for every recent run. This PR bumps it tov1.7.0, which supports Crystal >= 1.19.spec/markd_spec.crcompile-runsspec/fixtures/tartrazine.crvia{{ run(...) }}, which requires thetartrazinedevelopment dependency, soshards install --without-developmentbreaks spec compilation on every OS in the matrix. This PR drops that flag.Verification
.ameba.ymlafter the small lint fixes included here (unused assignment in the tartrazine fixture, macro expression spacing inNode#inspect, redundantreturnin the inline parser).crystal spec: 1422 examples, 0 failures.Note: PR #78 (footnotes) carries equivalent fixes on its branch; these changes are line-identical, so merging both should be conflict-free.