Skip to content

Use tartrazine render code block - #67

Merged
nobodywasishere merged 5 commits into
icyleaf:masterfrom
zw963:master
Jan 14, 2025
Merged

Use tartrazine render code block#67
nobodywasishere merged 5 commits into
icyleaf:masterfrom
zw963:master

Conversation

@zw963

@zw963 zw963 commented Jan 11, 2025

Copy link
Copy Markdown
Contributor

Please check following screenshot, it rendered by

\```crystal
puts "hello"
\```

image

Thanks

@trafico-bot trafico-bot Bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jan 11, 2025
@nobodywasishere

Copy link
Copy Markdown
Collaborator

Is it possible to make this an optional dependency? Want to limit the surface area as this lib is upstreamed into Crystal itself

@zw963

zw963 commented Jan 12, 2025

Copy link
Copy Markdown
Contributor Author

Is it possible to make this an optional dependency? Want to limit the surface area as this lib is upstreamed into Crystal itself

Done, now, markd only use tartrazine to render code block if require "tartrazine" before markd.

@zw963
zw963 force-pushed the master branch 4 times, most recently from 3359c3c to 8da9990 Compare January 14, 2025 06:25
@nobodywasishere

Copy link
Copy Markdown
Collaborator

Are you okay with this change @icyleaf? Apologies for ping.

@zw963

zw963 commented Jan 14, 2025

Copy link
Copy Markdown
Contributor Author

When I started add tartrazine, I was not aware that markd was an upstream dependency of the compiler.

Does it used for render code block like this in the comment of crystal source code?

Although, the behavior should be same if not add the crystal when write the markdown code block even tartrazine shards is available.

@icyleaf

icyleaf commented Jan 14, 2025

Copy link
Copy Markdown
Owner

LGTM

@nobodywasishere
nobodywasishere merged commit 588b172 into icyleaf:master Jan 14, 2025
@trafico-bot trafico-bot Bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jan 14, 2025
Comment thread src/markd/options.cr
@emoji = false,
@tagfilter = false,
@base_url = nil
@base_url = nil,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this rule failed, but don't know why this only failed on macOS ...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux may have failed too but CI was being wonky

@trafico-bot trafico-bot Bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jan 14, 2025
straight-shoota added a commit to straight-shoota/markd that referenced this pull request Aug 20, 2026
The `formatter` argument was added in icyleaf#67 but it's optional.

Adding a default value maintains API compatibility with v0.5.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ Merged Pull Request has been merged successfully 🔍 Ready for Review Pull Request is not reviewed yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants