Use tartrazine render code block - #67
Conversation
|
Is it possible to make this an optional dependency? Want to limit the surface area as this lib is upstreamed into Crystal itself |
Done, now, markd only use tartrazine to render code block if |
3359c3c to
8da9990
Compare
|
Are you okay with this change @icyleaf? Apologies for ping. |
|
When I started add tartrazine, I was not aware that markd was an upstream dependency of the compiler. Does it used for render code block like this in the comment of crystal source code? Although, the behavior should be same if not add the |
|
LGTM |
| @emoji = false, | ||
| @tagfilter = false, | ||
| @base_url = nil | ||
| @base_url = nil, |
There was a problem hiding this comment.
I saw this rule failed, but don't know why this only failed on macOS ...
There was a problem hiding this comment.
Linux may have failed too but CI was being wonky
The `formatter` argument was added in icyleaf#67 but it's optional. Adding a default value maintains API compatibility with v0.5.0.
Please check following screenshot, it rendered by
Thanks