Skip to content

Bump version to 2.8.3, add Phase 8 survey maturity roadmap#257

Merged
igerber merged 1 commit into
mainfrom
release/v2.8.3
Apr 2, 2026
Merged

Bump version to 2.8.3, add Phase 8 survey maturity roadmap#257
igerber merged 1 commit into
mainfrom
release/v2.8.3

Conversation

@igerber

@igerber igerber commented Apr 2, 2026

Copy link
Copy Markdown
Owner

Summary

Methodology references (required if estimator / math changes)

  • N/A — version bump and roadmap only, no methodology changes in this PR

Validation

  • Tests added/updated: No test changes (version bump + roadmap)
  • Backtest / simulation / notebook evidence: N/A

Security / privacy

  • Confirm no secrets/PII in this PR: Yes

Generated with Claude Code

Version bump covering silent warning audit (#256), replicate weight
expansion (#253), and imputation pre-period coefficients (#252).
Adds Phase 8 survey maturity roadmap (SDR, FPC expansion, lonely PSU,
CV, weight trimming, compatibility matrix).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Apr 2, 2026

Copy link
Copy Markdown

Overall Assessment

✅ Looks good

Executive Summary

  • No estimator implementation, weighting math, variance/SE code, defaults, or assumption checks changed in this diff.
  • Version propagation is consistent across the package, Rust crate, and machine-readable docs at diff_diff/init.py#L213, pyproject.toml#L7, rust/Cargo.toml#L3, and docs/llms-full.txt#L5.
  • P2: the new Phase 8b roadmap text misdescribes the current survey-variance path for ImputationDiD and TwoStageDiD as existing TSL support, which does not match the Methodology Registry or estimator docstrings.
  • P2: after adding the 2.8.3 release notes, the survey roadmap still says replicate weights are rejected for seven estimators that the changelog, Methodology Registry, and test suite show are supported.
  • P3: Phase 8c is added as planned work even though the same release notes and current code show those warnings are already implemented.

Methodology

  • Severity: P2. Impact: The newly added Phase 8b text in docs/survey-roadmap.md#L229 lines 229-236 says ImputationDiD and TwoStageDiD already have a TSL variance path and frames FPC as simply threading fpc through it. That does not match the canonical methodology notes, which say these estimators currently use survey-weighted Theorem 3 / GMM variance with PSU as the cluster variable, while strata only affects survey degrees of freedom; full stratified TSL/FPC support is not implemented yet in either estimator. See docs/methodology/REGISTRY.md#L884, docs/methodology/REGISTRY.md#L963, diff_diff/imputation.py#L213, and diff_diff/two_stage.py#L209. Concrete fix: rewrite 8b to describe the current implementation accurately and avoid implying that FPC support is just parameter plumbing through an existing TSL path.

Code Quality

  • Severity: None. Impact: The actual version bump is internally consistent across all touched version surfaces. Concrete fix: None.

Performance

  • Severity: None. Impact: This is a documentation/version diff; no runtime paths changed. Concrete fix: None.

Maintainability

  • Severity: P3. Impact: Survey-support status is duplicated across multiple docs, and this PR updates only some of them. The drift is already visible between docs/survey-roadmap.md#L93 lines 93-108 and the canonical support matrix in docs/methodology/REGISTRY.md#L2300. Concrete fix: keep the detailed support matrix in one canonical source and have roadmap/tutorial docs link to it rather than restating it.

Tech Debt

  • Severity: None. Impact: No new untracked technical debt in code paths; the only new debt is documentation drift noted above. Concrete fix: None.

Security

  • Severity: None. Impact: No secrets, dependency changes, or security-relevant code paths are introduced by this diff. Concrete fix: None.

Documentation/Tests

@igerber igerber merged commit dc277e3 into main Apr 2, 2026
15 checks passed
@igerber igerber deleted the release/v2.8.3 branch April 2, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant