Bumping ibc-go from 8.2.x to 8.3.x breaks ignite apps

[a26nine]

Describe the bug
With v28.5.0, ibc-go version was bumped from v8.2.0 to v8.3.1 [PR] and a new query router was added [PR]. These changes directly affected the downstream applications and broke the rollkit ignite app.

While running rollkit app built with ignite v28.5.x, the following error is thrown:

rollkit start \
    --rollkit.aggregator \
    --rollkit.da_auth_token $AUTH_TOKEN \
    --rollkit.da_namespace $DA_NAMESPACE \
    --rollkit.da_start_height $DA_BLOCK_HEIGHT \
    --minimum-gas-prices="0.025stake" \
    --rollkit.da_address http://localhost:26658/

panic: proto: could not resolve import "core/crypto/pb/crypto.proto": not found

goroutine 1 [running]:
github.com/cosmos/ibc-go/v8/modules/apps/27-interchain-accounts/host/keeper.newModuleQuerySafeAllowList()
	/Users/js/go/pkg/mod/github.com/cosmos/ibc-go/v8@v8.3.1/modules/apps/27-interchain-accounts/host/keeper/keeper.go:287 +0x7c
github.com/cosmos/ibc-go/v8/modules/apps/27-interchain-accounts/host/keeper.NewKeeper({0x108efa528, _}, {_, _}, {_, _}, {_, _}, {_, _}, ...)
	/Users/js/go/pkg/mod/github.com/cosmos/ibc-go/v8@v8.3.1/modules/apps/27-interchain-accounts/host/keeper/keeper.go:82 +0xa4
gm/app.(*App).registerIBCModules(0x14000e1ed88, {0x108ed2d28?, 0x140000b0020?})
	/Users/js/gm/app/ibc.go:118 +0x1b30
gm/app.New({0x108eb8728, 0x14000c276c0}, {0x108ed2d28, 0x140000b0020}, {0x0, 0x0}, 0x1, {0x108e6f620, 0x1400115cfc0}, {0x14000c26930, ...})
	/Users/js/gm/app/app.go:259 +0x604
gm/cmd/gmd/cmd.newApp({0x108eb8728, 0x14000c276c0}, {0x108ed2d28, 0x140000b0020}, {0x0, 0x0}, {0x108e6f620, 0x1400115cfc0})
	/Users/js/gm/cmd/gmd/cmd/commands.go:140 +0x78
github.com/rollkit/cosmos-sdk-starter/server.startApp[...](0x14000579a40, 0x108e59ba8, {0x108e5a2e0, 0x0, 0x0, 0x108e59ba0, 0x108e59b88})
	/Users/js/go/pkg/mod/github.com/rollkit/cosmos-sdk-starter@v0.0.0-20240826100644-1c45500296f4/server/start.go:77 +0x150
github.com/rollkit/cosmos-sdk-starter/server.StartHandler[...](_, {{0x0, 0x0, 0x0}, {0x108eda6b0, 0x140014d28d0}, 0x0, {0x0, 0x0}, {0x108efa528, ...}, ...}, ...)
	/Users/js/go/pkg/mod/github.com/rollkit/cosmos-sdk-starter@v0.0.0-20240826100644-1c45500296f4/server/start.go:49 +0xe8
github.com/cosmos/cosmos-sdk/server.StartCmdWithOptions.func2.1()
	/Users/js/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.9/server/start.go:198 +0x68
github.com/cosmos/cosmos-sdk/server.wrapCPUProfile(0x14000579a40, 0x1400128f9d8)
	/Users/js/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.9/server/start.go:570 +0x16c
github.com/cosmos/cosmos-sdk/server.StartCmdWithOptions.func2(0x14001343508, {0x14000abb140?, 0x0?, 0xc?})
	/Users/js/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.9/server/start.go:197 +0x184
github.com/spf13/cobra.(*Command).execute(0x14001343508, {0x14000abb080, 0xc, 0xc})
	/Users/js/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:985 +0x840
github.com/spf13/cobra.(*Command).ExecuteC(0x14000c1d808)
	/Users/js/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1117 +0x344
github.com/spf13/cobra.(*Command).Execute(...)
	/Users/js/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1041
github.com/spf13/cobra.(*Command).ExecuteContext(...)
	/Users/js/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1034
github.com/cosmos/cosmos-sdk/server/cmd.Execute(0x14000c1d808, {0x1074c5fd1, 0x2}, {0x16b0cb8bb, 0xd})
	/Users/js/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.9/server/cmd/execute.go:34 +0x154
main.main()
	/Users/js/gm/cmd/gmd/main.go:16 +0x44
Error intercepting command:  failed to run entrypoint: exit status 2

To dissect the issue, a custom build with v28.5.1 branch along with reverting of the following PRs:

• chore(templates): upgrade ibc to 8.3.1 #4168
• fix: register query router (follow-up of #4168) #4170

is created, and it resolves the issue. Thus, we can deduce that the issue stems from the changes in upstream.

To reproduce
Steps to reproduce the behavior:

1. ignite scaffold chain gm --address-prefix gm --no-module
2. cd $HOME/gm
3. ignite app install github.com/ignite/apps/rollkit@rollkit/v0.2.1
4. ignite rollkit add
5. ignite chain build
6. ignite rollkit init
7. rollkit toml init
8. rollkit start --rollkit.aggregator --rollkit.da_auth_token $AUTH_TOKEN --rollkit.da_namespace $DA_NAMESPACE --rollkit.da_start_height $DA_BLOCK_HEIGHT --minimum-gas-prices="0.025stake" --rollkit.da_address http://localhost:26658/

What version are you using?

v28.5.1

[julienrbrt]

I think this should fix it: cosmos/ibc-go#6436. Looks like a bug in IBC and not in ignite.
Let me check if we use the fixed version

[julienrbrt]

Mmh getting another proto error with ibc 8.5.0

[GMD] panic: proto: message field "plaintext.pb.Exchange.pubkey" cannot resolve type: resolved "crypto.pb.PublicKey", but "pb/crypto.proto" is not imported
[GMD] 
[GMD] goroutine 1 [running]:
[GMD] github.com/cosmos/ibc-go/v8/modules/apps/27-interchain-accounts/host/keeper.newModuleQuerySafeAllowList()
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/cosmos/ibc-go/v8@v8.5.0/modules/apps/27-interchain-accounts/host/keeper/keeper.go:296 +0x1ac
[GMD] github.com/cosmos/ibc-go/v8/modules/apps/27-interchain-accounts/host/keeper.NewKeeper({0x565b1e8, _}, {_, _}, {_, _}, {_, _}, {_, _}, ...)
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/cosmos/ibc-go/v8@v8.5.0/modules/apps/27-interchain-accounts/host/keeper/keeper.go:83 +0xcc
[GMD] gm/app.(*App).registerIBCModules(0x40011b3008, {0x55d2720, 0x40015cc540})
[GMD] 	/home/julien/downloads/gm/app/ibc.go:117 +0x1554
[GMD] gm/app.New({0x561d718, 0x4000da12d0}, {0x56386a0, 0x4000208290}, {0x0, 0x0}, 0x1, {0x55d2720, 0x40015cc540}, {0x4001186ee0, ...})
[GMD] 	/home/julien/downloads/gm/app/app.go:259 +0xd8c
[GMD] gm/cmd/gmd/cmd.newApp({0x561d718, 0x4000da12d0}, {0x56386a0, 0x4000208290}, {0x0, 0x0}, {0x55d2720, 0x40015cc540})
[GMD] 	/home/julien/downloads/gm/cmd/gmd/cmd/commands.go:141 +0x98
[GMD] github.com/rollkit/cosmos-sdk-starter/server.startApp[...](0x400155c880, 0x50bfdc0, {0x50c05a8, 0x0, 0x0, 0x50bfdb8, 0x50bfd98})
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/rollkit/cosmos-sdk-starter@v0.0.0-20240903134427-a534c349d387/server/start.go:77 +0x29c
[GMD] github.com/rollkit/cosmos-sdk-starter/server.StartHandler[...](_, {{0x0, 0x0, 0x0}, {0x563c7f0, 0x4001584f60}, 0x0, {0x4000ea99d8, 0x2}, {0x565b1e8, ...}, ...}, ...)
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/rollkit/cosmos-sdk-starter@v0.0.0-20240903134427-a534c349d387/server/start.go:49 +0x178
[GMD] github.com/cosmos/cosmos-sdk/server.StartCmdWithOptions.func2.1()
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.9/server/start.go:198 +0xa4
[GMD] github.com/cosmos/cosmos-sdk/server.wrapCPUProfile(0x400155c880, 0x400128f4e8)
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.9/server/start.go:570 +0x310
[GMD] github.com/cosmos/cosmos-sdk/server.StartCmdWithOptions.func2(0x40013fb808, {0x40015687e0, 0x0, 0x6})
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.9/server/start.go:197 +0x2f4
[GMD] github.com/spf13/cobra.(*Command).execute(0x40013fb808, {0x4001568720, 0x6, 0x6})
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:985 +0xbd8
[GMD] github.com/spf13/cobra.(*Command).ExecuteC(0x4000da7808)
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1117 +0x7d0
[GMD] github.com/spf13/cobra.(*Command).Execute(0x4000da7808)
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1041 +0x30
[GMD] github.com/spf13/cobra.(*Command).ExecuteContext(0x4000da7808, {0x5615510, 0x40015845a0})
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/spf13/cobra@v1.8.1/command.go:1034 +0x70
[GMD] github.com/cosmos/cosmos-sdk/server/cmd.Execute(0x4000da7808, {0x46c6609, 0x2}, {0xfffffe083011, 0x10})
[GMD] 	/home/julien/tools/go/pkg/mod/github.com/cosmos/cosmos-sdk@v0.50.9/server/cmd/execute.go:34 +0x120
[GMD] main.main()
[GMD] 	/home/julien/downloads/gm/cmd/gmd/main.go:16 +0x48
✘ Cannot run /home/julien/tools/go/bin/gmd              

[damiannolan]

Could we try generating a rollkit app using cosmos/ibc-go#7278?

[julienrbrt]

Could we try generating a rollkit app using cosmos/ibc-go#7278?

Hey, yep used v8.5.1-0.20240910150550-0e18b1d856b6 from your branch and it fixes the issue 🙏🏾

[damiannolan]

Could we try generating a rollkit app using cosmos/ibc-go#7278?

Hey, yep used v8.5.1-0.20240910150550-0e18b1d856b6 from your branch and it fixes the issue 🙏🏾

Thanks @julienrbrt! Appreciate you testing 🙏🏻 I'll merge and backport!