Skip to content

chore(templates): upgrade ibc to 8.3.1 (backport #4168) #4169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 3 commits into from
May 28, 2024
Merged

chore(templates): upgrade ibc to 8.3.1 (backport #4168) #4169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
811ff6e
chore(templates): upgrade ibc to 8.3.1 (#4168)
julienrbrt May 28, 2024
c29d996
fix: register query router (follow-up of #4168)
julienrbrt May 28, 2024
a556292
docs
julienrbrt May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@
### Changes

- [#4149](https://github.com/ignite/cli/pull/4149) Bump cometbft to `v0.38.7`
- [#4168](https://github.com/ignite/cli/pull/4168) Bump IBC to `v8.3.1`
If you are upgrading manually from `v8.2.0` to `v8.3.1`, add the following to your `ibc.go` file:

@julienrbrt julienrbrt May 28, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I instead list the command to use with gen-mig-diffs?
Supposedly: gen-mig-diffs --output changes.md --from v28.4.0 --to v28.5.0

@julienrbrt julienrbrt May 28, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @toschdev. do we have the docs / tutorials published for this? so we could link this insteand


```diff
app.ICAHostKeeper = ...
+ app.ICAHostKeeper.WithQueryRouter(app.GRPCQueryRouter())`
app.ICAControllerKeeper = ...
```

## [`v28.4.0`](https://github.com/ignite/cli/releases/tag/v28.4.0)

Expand Down
2 changes: 2 additions & 0 deletions ignite/templates/app/files/app/ibc.go.plush
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ func (app *App) registerIBCModules(appOpts servertypes.AppOptions) error {
app.MsgServiceRouter(),
authtypes.NewModuleAddress(govtypes.ModuleName).String(),
)
app.ICAHostKeeper.WithQueryRouter(app.GRPCQueryRouter())

app.ICAControllerKeeper = icacontrollerkeeper.NewKeeper(
app.appCodec,
app.GetKey(icacontrollertypes.StoreKey),
Expand Down
4 changes: 2 additions & 2 deletions ignite/templates/app/files/go.mod.plush
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ require (
github.com/cosmos/cosmos-sdk v0.50.6
github.com/cosmos/gogoproto v1.4.12
github.com/cosmos/ibc-go/modules/capability v1.0.0
github.com/cosmos/ibc-go/v8 v8.2.0
github.com/cosmos/ibc-go/v8 v8.3.1
github.com/golang/protobuf v1.5.4
github.com/gorilla/mux v1.8.1
github.com/grpc-ecosystem/grpc-gateway v1.16.0
Expand All @@ -47,5 +47,5 @@ require (
google.golang.org/genproto/googleapis/api v0.0.0-20240325203815-454cdb8f5daa
google.golang.org/grpc v1.63.2
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.3.0
google.golang.org/protobuf v1.33.0
google.golang.org/protobuf v1.34.1
)