Multiglass - #15
Open
mrexodia wants to merge 2 commits into
Open
Conversation
Some embedders (e.g. multiglass, where every shell tab runs as a push session) want the terminal to exist regardless of whether a hub is reachable at all — streaming is a bonus, not the point. Two additive, opt-in changes make that possible without touching the CLI/serve-api's existing default behavior: - PushOptions::eager_start starts the command immediately instead of gating it behind the first successful hub connect; registering and streaming then happen entirely in the background. - pty::start's new `passive` flag makes hub down/up notifications a full no-op for the wrapped terminal — no pause, no clear, no notice — so a hub that's down, flaky, or never shows up doesn't affect the terminal at all, only whether frames get pushed anywhere.
mrexodia
marked this pull request as ready for review
August 5, 2026 20:16
Contributor
Author
|
@iksteen graciously asking for your (clanker's) review. It looks like multiglass is working quite smoothly! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More of a draft for now, some minor changes for multiglass