Conversation
Two early returns in zend_call_function() skip zend_release_fcall_info_cache(): the one taken when zend_deprecated_function() leaves an exception pending, and the one taken when zend_handle_undef_args() fails. Both leak the trampoline, so a #[\Deprecated] __call() whose deprecation is promoted to an exception, and a missing required argument on Closure::__invoke(), each leak 256 bytes per call and trip the EG(trampoline) assertion in shutdown_executor().
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two early returns in
zend_call_function()skipzend_release_fcall_info_cache(): the one taken whenzend_deprecated_function()leaves an exception pending, and the one taken whenzend_handle_undef_args()fails. The three sibling early returns in the same function already release it. Both leak the trampoline, so a#[\Deprecated] __call()whose deprecation is promoted to an exception, and a missing required argument onClosure::__invoke(), each leak 256 bytes per call and trip theEG(trampoline)assertion inshutdown_executor()on a debug build.The test covers both sites independently: with either hunk reverted on its own it still fails.