Cover Ollama streaming tool calling with a test - #6
Merged
Conversation
ActuallyTaylor
force-pushed
the
feature/ollama-streaming-tool-calling
branch
from
August 3, 2026 19:36
f436f25 to
e666645
Compare
ActuallyTaylor
force-pushed
the
feature/ollama-streaming-tool-calling
branch
2 times, most recently
from
August 3, 2026 19:47
0cc74aa to
6933290
Compare
ActuallyTaylor
changed the base branch from
feature/central-tool-resolution
to
feature/gemini-streaming-tool-calling
August 3, 2026 19:48
ActuallyTaylor
force-pushed
the
feature/ollama-streaming-tool-calling
branch
from
August 3, 2026 20:03
6933290 to
b61a0ad
Compare
The streaming tool loop landed without a test, so nothing checked that tool activity reaches the transcript while the stream is still running rather than only at the end. `streamWithTools` asserts the tool calls and tool output entries appear during iteration, that the output survives into the final transcript, and that the tool was invoked once with the expected arguments. It mirrors the Anthropic suite's equivalent and reuses this suite's `spy(on:)` fixture.
ActuallyTaylor
force-pushed
the
feature/ollama-streaming-tool-calling
branch
from
August 3, 2026 20:07
b61a0ad to
970a262
Compare
ActuallyTaylor
commented
Aug 3, 2026
ActuallyTaylor
left a comment
Collaborator
Author
There was a problem hiding this comment.
Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope reduced. This PR originally added streaming tool calling to the Ollama provider, but #3 landed the same feature first — main's
streamResponsealready runs the turn loop, calls the shared resolver, and appends transcript entries mid-stream. Re-landing that would have been a duplicate, so the implementation is dropped.What remains is the piece #3 didn't include: a test. Nothing currently checks that tool activity reaches the transcript while the stream is running rather than only at the end.
streamWithToolsasserts the tool calls and tool output entries appear during iteration, that the output survives into the final transcript, and that the tool was invoked once with the expected arguments. It mirrors the Anthropic suite's equivalent and reuses this suite'sspy(on:)fixture.Verified live earlier against a local Ollama server with
qwen3:8b.Based on #4; merge that first.
🤖 Generated with Claude Code