fix: split CI into test + tag-triggered publish - #8
Conversation
royosherove
commented
May 7, 2026
- Test workflow: runs on push to main + PRs (satisfies branch protection)
- Publish workflow: only on v* tags (no auto-bump, no push to protected branch)
- Fixes the publish step failures from PRs feat: roundhouse bundle — skills sync, CLI tools, extensions #4-7
- Test workflow: runs on push to main + PRs - Publish workflow: only on v* tags (no auto-bump) - Fixes branch protection conflict in CI
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c513418538
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| on: | ||
| push: | ||
| branches: [main] | ||
| tags: ["v*"] |
There was a problem hiding this comment.
This workflow now publishes on any v* tag push, but it no longer enforces that the tagged commit is on main. In practice, any collaborator who can push tags can publish a package from an arbitrary or stale commit (for example, a feature branch commit that never passed the protected main merge path), which can ship unreviewed code to npm. Add a guard before npm publish (or an if condition) that verifies the tag SHA is reachable from origin/main.
Useful? React with 👍 / 👎.
#5 — Suppress npm deprecation spam: - Set NODE_NO_WARNINGS=1 when spawning gateway subprocess - All install commands already use stdio:'pipe' (hide npm stderr) #6 — Whisper/STT setup improvements: - Default voice=false on macOS (whisper pip install is heavy) - Add whisper check in postflight with install hint - Linux keeps voice=true (auto-install on first message) #8 — Simplify getting started: - 'roundhouse install' now deprecated with redirect to setup - Removed 60+ lines of redundant install logic from cli.ts - README Quick Start: 3 lines (npm install, setup, start) - Cleaned up unused imports (mkdir, writeFile, envQuote, etc.) Co-authored-by: Loki FastStart <loki@faststart.internal>