scopelink: motor assignment, rotator, and the parameter tab as it now stands - #39
Merged
Merged
Conversation
…ws them Follows the driver going to 1.1 in indi-3rdparty. The page gains a section on which motor drives what and a section on the rotator, describes the parameter groups as 1.1 separates them, says what a change to the assignment takes, and corrects a property name and two replacement characters. The screenshots were all re-taken in one sitting on a generation 3 controller running interface 1.1; the Rotator and Firmware tabs had no image before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows
indilib/indi-3rdpartyPR #1386, which takes the driver to 1.1. The page needs to change withit, and two things on it were already wrong.
which rotates and which ones the front flap is made of. It decides which devices the driver offers,
which calibrated travel belongs to which of them, and that the flap is opened by asking the controller
for the flap rather than by moving a motor.
INDI::RotatorInterface: what the calibrated travel means for theangles it will accept, that sync is an offset rather than a command sent to the controller, and what
reverse does not do.
its acceleration — and belongs to it whatever it is driving; a job group is the job. That distinction
is what 1.1 introduced.
PARAM_FOCUSER_INVERT_DIRECTIONin a copyableindi_setpropline. Ithas been
PARAM_MOTOR1_INVERT_DIRECTIONsince the parameters were generated from the firmware's owndescription.
starts and drives from that copy, so a new assignment is stored and not acted on until it has been
restarted — measured on hardware, where a rotator assigned while the controller ran was refused as
having no motor assigned to it until it was restarted. The page says so, and says that Restart
controller on the Parameters tab is what does it.
the controller should never have accepted; a device that refuses everything because the controller
has not restarted since it was assigned; and what a refused move means.
categoriesandscopelink.yamlgainrotators; the version row reads 1.1.interface 1.1, so the set is consistent with itself and with the driver as it stands.
rotator.webpand
firmware.webpare new — the Firmware tab had never had an image — andoptions.webphad to bere-taken regardless of this work, because it still offered a hardware generation the driver dropped.
The Parameters tab now takes two: the restart action sits ten rows below the assignment and no single
frame holds both, so
parameters.webpshows the bottom of the pane, where the file actions and therestart are, and
assignment.webpshows the assignment itself in the section that explains it.The rotator was photographed with the flap's motor lent to it, which is the only way a two motor
controller can show a rotator at all.