Adress code review comments on branch fix_648 - #701
Merged
Conversation
sv2518
commented
Nov 9, 2022
Collaborator
|
Looks like I missed something here. Will push manually. |
kaushikcfd
force-pushed
the
fix_648
branch
2 times, most recently
from
November 10, 2022 21:17
88f3cb6 to
12a4ead
Compare
…_entrypoint, add docs and error when there is more than one subkernel. Update how a subkernel is detected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change naming of
is_executableon Target class tosingle_subkernel_is_entrypoint,add docs and error when there is more than one subkernel.