Various typing/dataclasses fixes - #151
Merged
Merged
Conversation
So that one can keep doing arithmetic with the result of arithmetic without the type checker complaining
alexfikl
approved these changes
Oct 3, 2024
alexfikl
left a comment
Collaborator
There was a problem hiding this comment.
Left a few nitpicks, but overall very welcome changes :D The ArithmeticExpressionT should solve my sumpy issue too.
inducer
force-pushed
the
attrs-followup-1
branch
from
October 3, 2024 12:57
ccd4031 to
70dd9a8
Compare
inducer
force-pushed
the
attrs-followup-1
branch
from
October 3, 2024 12:58
70dd9a8 to
a178ca5
Compare
Owner
Author
|
Thanks for taking a look! There will be another batch of changes for pytato before the 2024.1 release, but I think I'll merge this first and tackle that set in a separate PR. |
inducer
marked this pull request as ready for review
October 3, 2024 13:01
Collaborator
Sounds good! I'll probably do pytential after the loopy changes land if you don't get to it first 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains:
CallWithKwargs.kw_parameters) that broke leap and dagrt.