Make pt.Array's axes taggable types - #170
Merged
Merged
Conversation
kaushikcfd
force-pushed
the
array_dot_axes
branch
3 times, most recently
from
October 20, 2021 02:27
331f9a9 to
d85a087
Compare
2 tasks
Collaborator
Author
|
The downstream failures can be addressed by a PR in |
inducer
reviewed
Oct 20, 2021
inducer
left a comment
Owner
There was a problem hiding this comment.
Thanks! Aside from the concerns below, this LGTM.
kaushikcfd
force-pushed
the
array_dot_axes
branch
from
October 20, 2021 19:06
d85a087 to
6f12dad
Compare
kaushikcfd
force-pushed
the
array_dot_axes
branch
from
October 20, 2021 19:10
6f12dad to
e7586b4
Compare
Owner
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
kaushikcfd
force-pushed
the
array_dot_axes
branch
4 times, most recently
from
October 31, 2021 23:57
41f748c to
f80a1cc
Compare
kaushikcfd
force-pushed
the
array_dot_axes
branch
2 times, most recently
from
November 7, 2021 05:22
959f61c to
3385a3d
Compare
inducer
reviewed
Nov 7, 2021
kaushikcfd
force-pushed
the
array_dot_axes
branch
from
November 8, 2021 02:00
3385a3d to
4c8938c
Compare
kaushikcfd
force-pushed
the
array_dot_axes
branch
from
November 8, 2021 02:08
4c8938c to
c2d0159
Compare
kaushikcfd
force-pushed
the
array_dot_axes
branch
from
November 9, 2021 01:47
c2d0159 to
fc80f6c
Compare
kaushikcfd
force-pushed
the
array_dot_axes
branch
from
November 21, 2021 20:45
fc80f6c to
d02c306
Compare
Owner
|
This seems to have a few CI failures still. To avoid downstream failures, please use a snippet like the following: |
kaushikcfd
force-pushed
the
array_dot_axes
branch
from
November 24, 2021 21:18
d02c306 to
51bc900
Compare
Collaborator
Author
|
Sorry, this was lacking a rebase on top of |
Owner
|
LGTM, thanks! |
inducer
enabled auto-merge (rebase)
November 25, 2021 00:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the axes of the arrays to be tagged.
Closes #61