distributed-lazy: delete unneeded temporaries after execution - #258
Merged
Conversation
Also move distributed stuff to distributed.py
inducer
reviewed
Feb 7, 2022
matthiasdiener
marked this pull request as ready for review
February 8, 2022 01:18
inducer
approved these changes
Feb 9, 2022
inducer
left a comment
Owner
There was a problem hiding this comment.
Thanks! LGTM subject to these minor fixes.
Comment on lines
+612
to
+621
| # Keep a count on how often each input name is used, | ||
| # in order to be able to free them. | ||
| partition_input_names_refcount: Dict[str, int] = {} | ||
|
|
||
| for pid in pids_to_execute: | ||
| for name in partition.parts[pid].all_input_names(): | ||
| if name in partition_input_names_refcount: | ||
| partition_input_names_refcount[name] += 1 | ||
| else: | ||
| partition_input_names_refcount[name] = 1 |
Owner
There was a problem hiding this comment.
This should be a @memoize_method on the partition. No need to recompute on every evaluation IMO. (Make sure to not modify the cached dictionary in place!)
|
|
||
| if __debug__: | ||
| for _, v in partition_input_names_refcount.items(): | ||
| assert v == 0 |
Owner
There was a problem hiding this comment.
Maybe also assert that the values are gone from context?
Co-authored-by: Andreas Klöckner <inform@tiker.net>
inducer
approved these changes
Feb 10, 2022
inducer
left a comment
Owner
There was a problem hiding this comment.
Thanks, LGTM! I'll aply the suggestion.
inducer
enabled auto-merge (squash)
February 10, 2022 20:00
Owner
|
This should be able to land after inducer/pytools#118 merges. |
Contributor
Author
It will need a new pytools release+conda package I guess. |
Owner
|
Yep, you're totally right. 🤦 Doing that now. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add-on for #148.
Should help with illinois-ceesd/mirgecom#599