Add deduplicate_data_wrappers - #264
Merged
Merged
Conversation
1 task
inducer
force-pushed
the
dedup-data-wrappers
branch
from
February 22, 2022 01:09
879f5ef to
42cf0e4
Compare
kaushikcfd
approved these changes
Feb 22, 2022
kaushikcfd
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this is a frequent problem, and shipping it as a pytato transform makes a lot of sense.
Left some minor implementation nits, otherwise LGTM!
inducer
force-pushed
the
dedup-data-wrappers
branch
from
February 22, 2022 04:33
42cf0e4 to
990d173
Compare
Owner
Author
|
Thanks for taking a look! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports inducer/grudge#218.
cc @matthiasdiener