Lower to index lambda refactor - #384
Merged
Merged
Conversation
Collaborator
Author
|
@inducer: I'm unable to make the MRO to pick the correct mapper methods for |
inducer
reviewed
Nov 7, 2022
kaushikcfd
force-pushed
the
lower_to_index_lambda_refactor
branch
from
November 9, 2022 15:35
37bb22a to
86eee87
Compare
kaushikcfd
marked this pull request as ready for review
November 9, 2022 15:36
Collaborator
Author
|
This is a bit annoying to review as the Tab makes the |
1 task
kaushikcfd
force-pushed
the
lower_to_index_lambda_refactor
branch
from
November 9, 2022 16:15
86eee87 to
b7d2190
Compare
Owner
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trie to implement the suggestions in #375 (comment)