Add distributed prepartitioning check based on _LocalSendRecvDepGatherer - #404
Closed
matthiasdiener wants to merge 4 commits into
Closed
Add distributed prepartitioning check based on _LocalSendRecvDepGatherer#404matthiasdiener wants to merge 4 commits into
matthiasdiener wants to merge 4 commits into
Conversation
matthiasdiener
marked this pull request as ready for review
December 14, 2022 03:40
matthiasdiener
force-pushed
the
pre-part-check2
branch
from
December 14, 2022 03:51
04bc7e2 to
a5db94e
Compare
Co-authored-by: Andreas Kloeckner <andreask@illinois.edu> Co-authored-by: Matt Smith <majosm@illinois.edu>
matthiasdiener
force-pushed
the
pre-part-check2
branch
from
December 15, 2022 03:10
2c835de to
c77e54e
Compare
Owner
|
I don't think this is helpful, sorry. It dilutes commit authorship, moves code to places where it shouldn't be, imports private symbols across module boundaries, and I think re-merging this into #393 will be more trouble than me redoing this from scratch. |
Owner
|
As it stands, these checks are now done as part of partitioning, see #401. |
Owner
|
Superseded by #434 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #391.
Based on #393.