Make get_dot_graph_from_partition work with duplicated computation - #417
Merged
inducer merged 1 commit intoMar 14, 2023
Merged
Conversation
majosm
force-pushed
the
partition-dot-graph-duplicated-computation
branch
4 times, most recently
from
February 1, 2023 20:39
f6ceb07 to
ca9205b
Compare
majosm
marked this pull request as ready for review
February 1, 2023 21:34
majosm
force-pushed
the
partition-dot-graph-duplicated-computation
branch
from
February 20, 2023 21:27
ca9205b to
a345fa6
Compare
inducer
force-pushed
the
partition-dot-graph-duplicated-computation
branch
from
March 8, 2023 19:20
a345fa6 to
51f96c4
Compare
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently each array is given a single name in the emitted dot code, even if it is computed by multiple parts. This can lead to strangeness like the duplicated edges entering the
_in0[_0, _1] + 1node in the graph below:This PR tweaks the code to make sure that each node to be emitted gets assigned a unique name. With the changes, the above graph becomes: