do not pickle cached hash of arrays - #563
Conversation
16c308b to
b8c0cae
Compare
inducer
left a comment
There was a problem hiding this comment.
Completely agree that this needs to be fixed. Just a few nits to pick below.
0b10fba to
9f3082a
Compare
|
A somewhat unorthodox thought - should we even cache the hash of dataclasses, or could we rely on that any "large" field of the dataclass (say, an What In case caching the hash is not needed, neither the custom hashing nor the caching of the hash would be necessary (but we would have to set This would also affect #566. |
Nevermind, for recursive data structures like the DAG we will need cached hashes. |
|
A gentle ping for a review @inducer |
|
Thanks, LGTM! |
Prevents errors of the type:
pytato.distributed.verify.MissingSendError: no send for 'CommunicationOpIdentifier(src_rank=1, dest_rank=0, comm_tag=('fluid', (<class 'mirgecom.diffusion._DiffusionStateTag'>, (<class 'y3prediction.prediction._SmoothCharDiffFluidCommTag'>, Placeholder(shape=(), dtype='int64', name='_actx_in_1'))), (0,)))'(see e.g. https://github.com/illinois-ceesd/mirgecom/actions/runs/11958222838/job/33337251412?pr=926)
cc @MTCam
Followup of #521.
Please squash