Remove usage of meshmode.dof_array.flatten and friends - #118
Merged
Conversation
alexfikl
marked this pull request as draft
October 22, 2021 21:56
alexfikl
force-pushed
the
remove-deprecated-flatten
branch
from
October 24, 2021 15:57
eb1d69c to
e7f59e8
Compare
alexfikl
marked this pull request as ready for review
October 24, 2021 20:14
Owner
|
Could you request review here so I have this in my email? I only saw this by accident. |
Collaborator
Author
Should be requested now. I forgot about it too after it finally passed the CI 🤦. |
alexfikl
force-pushed
the
remove-deprecated-flatten
branch
from
November 9, 2021 14:30
6301c7c to
af54518
Compare
alexfikl
force-pushed
the
remove-deprecated-flatten
branch
from
December 15, 2021 03:29
af54518 to
ed237bf
Compare
alexfikl
force-pushed
the
remove-deprecated-flatten
branch
from
January 12, 2022 15:33
ed237bf to
4653891
Compare
inducer
reviewed
Jan 13, 2022
alexfikl
force-pushed
the
remove-deprecated-flatten
branch
3 times, most recently
from
January 13, 2022 15:53
78bef69 to
7743430
Compare
alexfikl
force-pushed
the
remove-deprecated-flatten
branch
from
January 13, 2022 16:33
7743430 to
f9d5fcd
Compare
Owner
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
Add astype to PyOpenCLArrayContext arraycontext#114