Taggable: Do not force copy for tag setting - #120
Merged
Merged
Conversation
copy for tag setting
inducer
force-pushed
the
with-new-tags
branch
3 times, most recently
from
February 21, 2022 04:38
f55928e to
da2b59b
Compare
inducer
force-pushed
the
with-new-tags
branch
from
February 21, 2022 05:07
da2b59b to
57c0172
Compare
1 task
Owner
Author
|
Not hearing loud objections, been running it locally. I'll proceed with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on inducer/arraycontext#147 (comment).
It's not safe to assume
copyis the right verb for tag application, it's taken e.g. forpyopencl.array.Array. Leave more of the actual detail to the subclass.np.errstateto raise on numpy errors, instead of a warning filter pytato#262cc @alexfikl @kaushikcfd