Add stacked markdown review comments#489
Draft
lmist wants to merge 1 commit into
Draft
Conversation
|
|
|
I could not sync this PR automatically. A maintainer will look into it. The diff could not be applied on our side. This is a bridge-side issue, not a problem with your PR (which is already based on the latest public base); a maintainer will look into it. |
Contributor
|
Hey @lmist, thanks for the contribution. We have some internal work ongoing for this feature, but we will take your work into account as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds inline review comments for selected text in the WYSIWYG markdown editor. Users can select arbitrary passages, add multiple anchored comments, review them in the right-side Comments panel, and prepare the collected feedback for agent handoff.
Known issue: in manual testing, clicking Send currently appears to do nothing. This PR leaves that behavior as a follow-up and calls it out explicitly.
How this was verified
Targeted checks passed:
bun run test:dom src/editor/comments/CommentSelectionButton.dom.test.tsx src/components/DocPanel.dom.test.tsx src/components/DocumentCommentsPanel.dom.test.tsxbun test --timeout 30000 --conditions development src/editor/comments/comment-store.test.tsbun run typecheck --filter @inkeep/open-knowledge-appgit diff --checkManual UI screenshot:
This screenshot shows selected markdown text highlighted in the editor, stacked comments in the right-side Comments panel, comment editing, and code-block selection highlighting.
Checklist
bun run check(lint, typecheck, tests) locallybun run changeset) if this changes behavior