Skip to content
This repository was archived by the owner on Sep 9, 2025. It is now read-only.

docs: Update publish strategy to include Ollama publishing#70

Merged
nathan-weinberg merged 3 commits into
instructlab:mainfrom
alinaryan:update-publish-strat
Jun 3, 2024
Merged

docs: Update publish strategy to include Ollama publishing#70
nathan-weinberg merged 3 commits into
instructlab:mainfrom
alinaryan:update-publish-strat

Conversation

@alinaryan

@alinaryan alinaryan commented May 31, 2024

Copy link
Copy Markdown
Contributor

Add Ollama publishing scheme to the dev-docs.

Resolves #65

@alinaryan alinaryan added the documentation Improvements or additions to documentation label May 31, 2024
@alinaryan alinaryan self-assigned this May 31, 2024
@alinaryan
alinaryan force-pushed the update-publish-strat branch 2 times, most recently from 31b0489 to 077b66a Compare May 31, 2024 19:03

@russellb russellb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

@bjhargrave

bjhargrave commented May 31, 2024

Copy link
Copy Markdown
Contributor

There is some overlap with instructlab/community#198 ? Or are they unrelated?

@russellb

Copy link
Copy Markdown
Contributor

There is some overlap with instructlab/community#198 ? Or are they unrelated?

looks more unrelated to me. This one is about what happens when we publish new model builds (where they go, naming conventions)

That other doc is more of a user doc -- how to use ollama with our models. This doc might need some updates to reflect how we publish there. Some things might be easier. I'd defer to @alinaryan on that.

Either way, I think both docs make sense for different purposes.

@nathan-weinberg nathan-weinberg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit but otherwise LGTM

Comment thread docs/publish-strategy.md Outdated
@nathan-weinberg

Copy link
Copy Markdown
Contributor

Spellcheck needs to be fixed as well

russellb added a commit to russellb/instructlab-dev-docs that referenced this pull request May 31, 2024
This came up in review on instructlab#70, so document the preferred
capitalization.

Signed-off-by: Russell Bryant <rbryant@redhat.com>

@cdoern cdoern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one capitalization fix pending

Comment thread docs/publish-strategy.md Outdated
alinaryan added 2 commits June 3, 2024 10:19
Signed-off-by: Alina Ryan <aliryan@redhat.com>
Signed-off-by: Alina Ryan <aliryan@redhat.com>
@alinaryan
alinaryan force-pushed the update-publish-strat branch from 077b66a to 38d0d5d Compare June 3, 2024 14:20
Signed-off-by: Alina Ryan <aliryan@redhat.com>
@alinaryan

Copy link
Copy Markdown
Contributor Author

Spellcheck needs to be fixed as well

@nathan-weinberg Added a commit

@cdoern cdoern left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nathan-weinberg
nathan-weinberg merged commit 6ccd2bf into instructlab:main Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update publishing strategy to include ollama publishing

5 participants