Better path and string handling#106
Merged
Merged
Conversation
nathan-weinberg
approved these changes
Aug 22, 2024
Contributor
|
pathlib.Path is the string-handling mechanism in the CLI, would there be any interest in switching over for this library? |
Removing several leftover cases of paths formed without os.path.join Replacing string concats with f"" Signed-off-by: Dan McPherson <dmcphers@redhat.com>
Contributor
Author
I would generally prefer pathlib.Path but I was trying to make the simplest change. We also aren't really doing any operations here where the niceties of pathlib.Path would come in handy. |
Member
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
jaideepr97
approved these changes
Sep 12, 2024
Member
|
Mergify rules have changed since this was opened thus no automerge - doing so manually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing several leftover cases of paths formed without os.path.join
Replacing string concats with f""