Use single answer file and model list#110
Merged
Merged
Conversation
Since phased training is using individual model names for judgment, it's hitting the case where multiple models are being loaded for evaluation. We don't currently need that code path as it was inherited from FastChat so this change removes it and relies on the single answerfile and its model type. Signed-off-by: Dan McPherson <dmcphers@redhat.com>
Signed-off-by: Dan McPherson <dmcphers@redhat.com>
nathan-weinberg
approved these changes
Aug 27, 2024
Contributor
Contributor
Author
|
@Mergifyio backport main |
Contributor
✅ Backports have been createdDetails
|
nathan-weinberg
added a commit
that referenced
this pull request
Aug 28, 2024
Use single answer file and model list (backport #110)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since phased training is using individual model names for judgment, it's hitting the case where multiple models are being loaded for evaluation. We don't currently need that code path as it was inherited from FastChat so this change removes it and relies on the single answerfile and its model type.