Remove max_workers and serving_gpus from constructor#140
Merged
Conversation
This change is not backward compatible with callers using max_workers or serving_gpus in the constructor. A minor version bump should be made for the next release. Any callers to max_workers= or serving_gpus= in the constructor should switch to use gen_answers and judge_answers for MTBenchEvaluator and MTBenchBranchEvaluator. Signed-off-by: Dan McPherson <dmcphers@redhat.com>
Contributor
Author
|
@sallyom FYI |
alinaryan
approved these changes
Sep 27, 2024
nathan-weinberg
approved these changes
Sep 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes max_workers from the constructor in favor of passing to judge_answers and gen_answers. The original change was made because workers should be dependent on the particular settings of the model being served which can vary between the model being judged and the judge itself.
Any callers to max_workers= or serving_gpus= in the constructor should switch to use gen_answers and judge_answers for MTBenchEvaluator and MTBenchBranchEvaluator.
Original change made here: #107
CLI updated here: instructlab/instructlab#2144
This change is not backward compatible with callers using max_workers or serving_gpus in the constructor. A minor version bump should be made for the next release.