Skip to content

Give nice error for empty taxonomy#151

Merged
mergify[bot] merged 1 commit into
instructlab:mainfrom
danmcp:emptytaxonomy
Oct 21, 2024
Merged

Give nice error for empty taxonomy#151
mergify[bot] merged 1 commit into
instructlab:mainfrom
danmcp:emptytaxonomy

Conversation

@danmcp

@danmcp danmcp commented Oct 14, 2024

Copy link
Copy Markdown
Contributor

Previously, if the taxonomy didn't contain any skills, an exception would have occurred. This fix gives a nicer message for the user.

Resolves #150

New output example:

...
INFO 2024-10-14 16:54:45,921 instructlab.model.backends.vllm:489: Waiting for GPU VRAM reclamation...
Provided taxonomy doesn't contain any skill qna.yaml files

Previously, if the taxonomy didn't contain any skills, an exception would have occurred.  This fix gives a nicer message for the user.

Signed-off-by: Dan McPherson <dmcphers@redhat.com>
@mergify mergify Bot added the one-approval label Oct 18, 2024
@nathan-weinberg
nathan-weinberg self-requested a review October 18, 2024 22:12
@mergify
mergify Bot merged commit 336a2e8 into instructlab:main Oct 21, 2024
@mergify mergify Bot removed the one-approval label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No skills in your taxonomy results in stack trace for mt_bench_branch

3 participants