Skip to content
This repository was archived by the owner on Apr 30, 2026. It is now read-only.

ci: add AWS tag to show github PR number for all jobs#264

Merged
nathan-weinberg merged 1 commit into
instructlab:mainfrom
nathan-weinberg:aws-metadata
Sep 3, 2024
Merged

ci: add AWS tag to show github PR number for all jobs#264
nathan-weinberg merged 1 commit into
instructlab:mainfrom
nathan-weinberg:aws-metadata

Conversation

@nathan-weinberg

@nathan-weinberg nathan-weinberg commented Sep 3, 2024

Copy link
Copy Markdown
Member

right now we can see what type of runner and which repository an AWS runner is associated with, but not which PR number triggered it

see instructlab/instructlab#2183 for reference

@nathan-weinberg
nathan-weinberg requested a review from a team September 3, 2024 15:10

@danmcp danmcp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we determined from here: instructlab/instructlab#2183 this probably isn't the best approach.

@nathan-weinberg

Copy link
Copy Markdown
Member Author

I think we determined from here: instructlab/instructlab#2183 this probably isn't the best approach.

Should we try github.event.pull_request.number? cc @russellb

@danmcp

danmcp commented Sep 3, 2024

Copy link
Copy Markdown
Contributor

I think we determined from here: instructlab/instructlab#2183 this probably isn't the best approach.

Should we try github.event.pull_request.number? cc @russellb

It looks like github.event.number should work

@nathan-weinberg nathan-weinberg changed the title ci: add AWS tag to show github ref for all jobs ci: add AWS tag to show github PR number for all jobs Sep 3, 2024
right now we can see what type of runner and which
repository an AWS runner is associated with, but not
which PR number triggered it

Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg
nathan-weinberg merged commit 47cabbb into instructlab:main Sep 3, 2024
@nathan-weinberg
nathan-weinberg deleted the aws-metadata branch September 3, 2024 20:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants