Repository navigation
Conversation
…to 1.11.1 Users updating from a pre-File-Provider version with an active session never got Files.app configured until they logged out and back in: - SharedAuthKeychain: read tokens stored in chunks by SecureStore (large JWTs never exist under the plain key), stop wiping the shared items when the private read fails (logout clears them explicitly), and write in place (update/add) so the extension never hits the delete-then-add gap. - silentSignInThunk now pushes native credentials on session restore, so the domain is registered and stabilized on first launch after an update; devices already broken self-heal without re-login. - Bump version to 1.11.1 (Android versionCode 131) across package.json, build.gradle, strings.xml, Info.plist and Expo.plist.
terrerox
force-pushed
the
release-1.11.1
branch
from
September 1, 2026 03:35
8ea4edb to
5194422
Compare
CandelR
reviewed
Sep 28, 2026
| newToken: credentials.photosToken, | ||
| }); | ||
|
|
||
| await syncNativeCredentials(credentials.photosToken, credentials.user); |
Contributor
There was a problem hiding this comment.
This won't sync for sessions from 1.10.x or older: syncNativeCredentials returns early at line 46 because rootFolderUuid is only set on sign-in since 1.11.0. rootFolderId is already the root folder uuid. Can we use it at lines 46 and 56?
| }); | ||
|
|
||
| it('when the logout completes, then clearCredentials is invoked', async () => { | ||
| test('when an existing session is restored at startup, then the wrapper receives the stored token', async () => { |
Contributor
There was a problem hiding this comment.
The test user (line 73) has rootFolderUuid, so this passes but doesn't cover the real case. Can we use a user with only rootFolderId, like a session from an older version?
|
CandelR
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users updating from a pre-File-Provider version with an active session never got Files.app configured until they logged out and back in: