Repository navigation
[PB-6778] feature/Mail - #633
Merged
Merged
Conversation
[PB-6629] Add mail to the app
[PB-6787] feature/Limit and clean up the attachments of every outgoing message
CandelR
marked this pull request as ready for review
October 6, 2026 06:37
[_]: bugfix/Mail QA fixes
Opening the upload menu took about 560 ms to respond because any change in the store repainted the whole drive list, through two paths: the drive items selector returned a new object on every call, and the app root subscribed to the entire ui slice and re-rendered the drive context with it.
A draft saved with an empty body showed "<p></p>" when reopened, and on iOS a body shorter than 13 characters showed its tags, because the native editor reads those values as plain text. The second case is a bug of react-native-enriched-html 1.1.1.
On Android the editor gives back an empty string for an empty body, which the crypto library rejects, so a draft with recipients and no body could not be saved. It is now saved with an empty paragraph, like on iOS and mail-web.
The pattern that detects a body made only of empty paragraphs let the blank space between two paragraphs match in two places, so a body with many blank lines followed by text took exponential time to be rejected. It now runs on the body without blank space, which the function already computes.
[_]: bugfix/Mail QA fixes 2
[_] feature/Bump the app version to 1.12.0
larryrider
previously approved these changes
Oct 6, 2026
|
larryrider
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings Internxt Mail.
Summary
@internxt/sdkis bumped to 1.20.2 and the unit test workflow runs on Node 22.