Repository navigation
[PB-6870]:feat/make max previewable file size configurable via env - #2185
Open
jaaaaavier wants to merge 4 commits into
Open
jaaaaavier wants to merge 4 commits into
jaaaaavier wants to merge 4 commits into
Conversation
Deploying drive-web with
|
| Latest commit: |
dc96086
|
| Status: | 🚫 Build failed. |
|
jaaaaavier
marked this pull request as ready for review
September 30, 2026 07:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to make the threshold for determining whether a file can be previewed adjustable without having to modify the code. To do this, we’ll use the variable
REACT_APP_MAX_PREVIEWABLE_FILE_SIZE_IN_MB, which will now be the variable used for this purpose, we’ll keep the existing setting as a fallback.Related Issues
Related Pull Requests
Checklist
Testing Process
Additional Notes
We will need to add a new env variable in cloudflare, both preview & production