Skip to content

[PB-6914]: feat/ask users with a pending account setup to finish it from their email - #2192

Merged
xabg2 merged 5 commits into
featurew/sign-up-passwordless-for-checkoutfrom
feat/PB-6914-pending-account-setup-on-login
Oct 6, 2026
Merged

xabg2 merged 5 commits into
featurew/sign-up-passwordless-for-checkoutfrom
feat/PB-6914-pending-account-setup-on-login

Conversation

@xabg2

@xabg2 xabg2 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Description

Customers who paid but haven't finished setting up their account now know what to do if they try to log in or sign up again with that email (PB-6873).

  • Login, the regular sign-up and the sign-ups from a shared item or workspace invitation show "finish setting up your account" instead of an invalid credentials or generic error.
  • A button resends the setup email and confirms it was sent, or shows an error so the user can retry.
  • Every other login and sign-up error behaves as before.

Related Issues

  • PB-6914 (subtask of PB-6873)

Related Pull Requests

Checklist

  • Changes have been tested locally.
  • Unit tests have been written or updated as necessary.
  • The code adheres to the repository's coding standards.
  • Relevant documentation has been added or updated.
  • No new warnings or errors have been introduced.
  • SonarCloud issues have been reviewed and addressed.
  • QA Passed

Testing Process

Unit tests for the notice (resend success and failure), the login screen, the regular sign-up form and both invitation sign-ups (pending setup shows the notice; other errors unchanged), and for the auth service keeping the pending setup code from the first login call. tsc, lint, the i18n check and the login, sign-up and services test suites pass.

Additional Notes

Non-English translations are drafts and should be reviewed.

@xabg2 xabg2 added the enhancement New feature or request label Sep 29, 2026
@xabg2 xabg2 self-assigned this Sep 29, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Deploying drive-web with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9165bcb
Status:⚡️  Build in progress...

View logs

@xabg2
xabg2 marked this pull request as ready for review September 30, 2026 09:43
Comment thread src/views/Login/components/LogIn.tsx
Comment thread src/views/Signup/components/SignupForm.tsx
@xabg2
xabg2 requested a review from CandelR October 6, 2026 11:22
@xabg2
xabg2 changed the base branch from master to featurew/sign-up-passwordless-for-checkout October 6, 2026 11:23
@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

@xabg2
xabg2 merged commit dc88df5 into featurew/sign-up-passwordless-for-checkout Oct 6, 2026
0 of 3 checks passed
@xabg2
xabg2 deleted the feat/PB-6914-pending-account-setup-on-login branch October 6, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants