Repository navigation
[MKT-1057]Fix/failed payment in klarna and paypal send purchase done event - #2196
Merged
internxt-yu merged 5 commits intoOct 5, 2026
Conversation
Deploying drive-web with
|
| Latest commit: |
19045b8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f5b5f910.drive-web.pages.dev |
| Branch Preview URL: | https://fix-failed-payment-in-klarna.drive-web.pages.dev |
internxt-yu
changed the base branch from
master
to
fix/google-tracking-problem
September 30, 2026 16:03
internxt-yu
added this pull request to stack #2197
September 30, 2026 16:04
|
internxt-yu
marked this pull request as ready for review
October 1, 2026 07:36
internxt-yu
requested review from
CandelR,
larryrider and
xabg2
as code owners
October 1, 2026 07:36
internxt-yu
marked this pull request as draft
October 1, 2026 07:37
internxt-yu
marked this pull request as ready for review
October 1, 2026 09:09
CandelR
requested changes
Oct 1, 2026
xabg2
reviewed
Oct 1, 2026
internxt-yu
force-pushed
the
fix/failed-payment-in-Klarna-and-paypal-send-purchase-done-event
branch
from
October 1, 2026 12:55
e2f4a8f to
03f1b51
Compare
internxt-yu
force-pushed
the
fix/failed-payment-in-Klarna-and-paypal-send-purchase-done-event
branch
from
October 2, 2026 09:50
0138820 to
943ccea
Compare
internxt-yu
force-pushed
the
fix/failed-payment-in-Klarna-and-paypal-send-purchase-done-event
branch
from
October 2, 2026 09:52
943ccea to
40591c6
Compare
CandelR
reviewed
Oct 2, 2026
CandelR
approved these changes
Oct 2, 2026
CandelR
left a comment
Collaborator
There was a problem hiding this comment.
Ready for QA @internxt-yu
internxt-yu
force-pushed
the
fix/failed-payment-in-Klarna-and-paypal-send-purchase-done-event
branch
from
October 5, 2026 07:04
7868e5a to
19045b8
Compare
|
internxt-yu
deleted the
fix/failed-payment-in-Klarna-and-paypal-send-purchase-done-event
branch
October 5, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We noticed that in Google Analytics shows purchases that not exists in Stripe done transactions and after investigation we saw that were failed purchase actions paying by Klarna or Paypal, which leave our checkout page to complete the purchase. After this, when the user returns, it redirected to checkoutSuccessfulView, whether the payment is done correctly or is failed, the purchase event is sent.
The change is basically adding a conditional check if the payment is successful or not, to see if the purchase event has to be sent to tracking sites or not.
The solution was in checkoutSuccessVIew add a method that check in the return URL of Stipe the status of payment. (SetupIntent when Stripe store the payment method to future payment; PaymentIntent when the payment is done directly, if the Intent was requested with wrong method, it return error).
We send the purchase tracking event is the purchase was successful with the return status of succeeded and ignore for the rest of status.
Related Issues
Related Pull Requests
Checklist
Testing Process
The testing process was in the checkout page do a test payment:
Screencast from 2026-10-01 09-02-17.webm
Additional Notes